Expose close status codes for WebSockets #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubik-cube-man
force-pushed
the
expose-error-codes
branch
from
94f6d32 to
77ff28d
Compare
|
I pushed a fix for the formatting that caused the pipeline to fail! |
rubik-cube-man
force-pushed
the
expose-error-codes
branch
from
77ff28d to
9babc47
Compare
jmartisk
approved these changes
Nov 15, 2023
|
This makes sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make WebSocket close exceptions expose the status code given by the server.
As it stands, there is no nice way to check the reason the WebSocket was closed. At the moment, in my code, I'm just checking if the message contains a String. This change would allow you to check the close status code for the WebSockets termination and handle it accordingly.