fix TCK issue #2152
Closed
fix TCK issue #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartisk
reviewed
Jul 29, 2024
| repository: quarkusio/quarkus | ||
| ref: main | ||
| repository: mskacelik/quarkus | ||
| ref: srgql-tck-fix |
There was a problem hiding this comment.
could you name it srgql-2.9.1 or something? It's quite likely that we will need to add more changes to that branch...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix:#2148
The problem was that
getAnnotations(type)only looked for the most outer wrapper; for example, for type@A List<@B C>,it only returnedAbut notA, B. This was because I changed it in the fa02098 commit.That said, I am not sure why the SRGQL TCK did not fail and Quarkus did...
I will delete the overridden configuration (outputs.json) on Quarkus when a new version of SRGQL is released...