-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add api group names for typesafe clients #2169
Conversation
Hi, thanks for your PR. But TBH I'm not yet completely sure we want this. The grouping feature on the server side probably didn't prove very useful (it's not how GraphQL schemas are usually created) - maybe @phillip-kruger has more thoughts on that, as he implemented it? We also removed it from the docs because we don't really recommend using it. On the client side, this would be closely tied to how specifically the SmallRye GraphQL server side does it, but mostly useless for calling GraphQL services based on anything else. |
Hi Jan. I can't agree with. Grouping api by any type can create structured api. For example, in rest we can create api like Also for example, in nodejs you can do schema like (or more nesting)
I think it may be very useful for big api if create it right. Becouse in my project there are already about 1k endpoints... For example, there is methods like getCustomerRequestsManagementServiceCustomerRequestPositionsById. This is pain)) The Graphql spec allows namespaces. And I think that removed it may be not best idea, becouse it can be someone use. |
Could you add a note into the documentation please? (probably into |
@jmartisk yes. of course |
@jmartisk please, check it |
I can't see any documentation changes, maybe you didn't push it? |
@jmartisk please, sorry. I made a mistake with PR 😑. |
@jmartisk I have added what I think is enough detail about namespaces for both server and client. Please take a look. Maybe you'll tell me that everything is bad =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely outstanding! Thanks!
Btw I'm planning to release SR-GQL 2.10 around this Friday, to catch the Quarkus 3.15 release train, so if you have any more stuff that you think should be included, please let me know, I may forget things... |
Yeah, merged that one too, thanks |
See #2173
Server implementation allows create api groups
and create queries like
But typesafe client has not this. This code
build not correct query (it not conains User wrapper on methods)
This PR fix it