Improve context based healthchecks #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xstefank
requested changes
Jan 2, 2024
| private <T> HealthRegistry register(String id, T check, Map<String, T> checks) { | ||
| var alreadRegisteredCheck = checks.putIfAbsent(id, check); | ||
| if (Objects.nonNull(alreadRegisteredCheck)) { | ||
| throw new IllegalStateException(String.format("Check for ID '%s' already registerds", id)); |
There was a problem hiding this comment.
Suggested change
| throw new IllegalStateException(String.format("Check for ID '%s' already registerds", id)); | |
| throw new IllegalStateException(String.format("Check for ID '%s' already registered", id)); |
Also, this would be a change in behavior. Do you need this for your use case?
There was a problem hiding this comment.
No this change actually has nothing to do with my usecase. I'll revert that.
| import io.smallrye.health.api.Wellness; | ||
|
|
||
| @ApplicationScoped | ||
| public class ContextHealthCheckRegistrar { |
There was a problem hiding this comment.
This class is not used by the test.
|
@HerrDerb, if you could also squash the commits, it would be great. Thanks! |
HerrDerb
force-pushed
the
improve-context-based-healthchecks
branch
from
76ec26e to
d2d7e16
Compare
xstefank
approved these changes
Jan 3, 2024
|
Thanks @HerrDerb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.