Support for the 'jwk' JWT header #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeEdgar
previously approved these changes
Mar 20, 2024
implementation/jwt-build/src/test/java/io/smallrye/jwt/build/JwtSignTest.java
Outdated
Show resolved
Hide resolved
implementation/jwt-build/src/test/java/io/smallrye/jwt/build/JwtSignTest.java
Show resolved
Hide resolved
sberyozkin
force-pushed
the
jwt_build_jwk_header
branch
from
d283fce to
d2ed909
Compare
|
Hi Mike @MikeEdgar I removed the duplicate assertion in the test and it lost your approval, so I'll merge once it is green |
Skyllarr
approved these changes
Mar 21, 2024
|
Thanks @MikeEdgar @Skyllarr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #770
This PR makes it easy to set a
jwktoken header, and is also a preparation for the DPoP work.I'll be planning to do a release once this PR is reviewed and merged