Introducing a facade API : #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ehsavoie
commented
Oct 15, 2024
ehsavoie
commented
- Adding MP annotations to replace the LangChain4J ones.
- Registering AI services factories to use SmallRye default factories instead of Langchain4J default services.
- All examples now run with the MP annotations instead of Langchain4J annotations.
- Cleaning the poms
* Adding MP annotations to replace the LangChain4J ones. * Registering AI services factories to use SmallRye default factories instead of Langchain4J default services. * All examples now run with the MP annotations instead of Langchain4J annotations. * Cleaning the poms Signed-off-by: Emmanuel Hugonnet <[email protected]>
yblazart
approved these changes
Oct 15, 2024
This was referenced Oct 16, 2024
Emily-Jiang
reviewed
Oct 16, 2024
There was a problem hiding this comment.
I have concerns with forking the Langchain4J APIs and put the microprofile namespace. I think a better model is to use LangChain4J as a upstream dependency. @cescoffier please provide your thoughts on this.
|
Agreed with you @Emily-Jiang Don't underestimate the amount of abstraction you will have to handle. It's more than |
ehsavoie
added a commit
to ehsavoie/smallrye-llm
that referenced
this pull request
Oct 31, 2024
This reverts commit b3b6794.
ehsavoie
added a commit
that referenced
this pull request
Nov 4, 2024
* Revert "Introducing a facade API : (#53)" This reverts commit b3b6794. * Removing the role as it doesn't exist in smallrye Signed-off-by: Emmanuel Hugonnet <[email protected]> --------- Signed-off-by: Emmanuel Hugonnet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.