-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to JCTools #1334
Refactor to JCTools #1334
Conversation
Todo:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1334 +/- ##
============================================
+ Coverage 88.77% 88.92% +0.14%
+ Complexity 3342 3266 -76
============================================
Files 459 456 -3
Lines 13438 13218 -220
Branches 1655 1640 -15
============================================
- Hits 11930 11754 -176
+ Misses 840 813 -27
+ Partials 668 651 -17
|
45ab8a0
to
97d8874
Compare
97d8874
to
8535f58
Compare
emitter() fails in native
Note: this scratchpad branch will never be merged, a clean commit will be eventually done |
implementation/src/main/java/io/smallrye/mutiny/helpers/queues/Queues.java
Outdated
Show resolved
Hide resolved
implementation/src/main/java/io/smallrye/mutiny/helpers/queues/Queues.java
Show resolved
Hide resolved
implementation/src/main/java/io/smallrye/mutiny/helpers/queues/Queues.java
Outdated
Show resolved
Hide resolved
implementation/src/main/java/io/smallrye/mutiny/helpers/queues/Queues.java
Outdated
Show resolved
Hide resolved
...tation/src/main/java/io/smallrye/mutiny/operators/multi/builders/BufferItemMultiEmitter.java
Outdated
Show resolved
Hide resolved
...tation/src/main/java/io/smallrye/mutiny/operators/multi/builders/BufferItemMultiEmitter.java
Show resolved
Hide resolved
...ation/src/main/java/io/smallrye/mutiny/operators/multi/overflow/MultiOnOverflowBufferOp.java
Outdated
Show resolved
Hide resolved
This reverts commit 101926c.
…size() which is not constant-time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more comments, mostly naming, really, so feel free to ignore
implementation/src/main/java/io/smallrye/mutiny/helpers/queues/Queues.java
Outdated
Show resolved
Hide resolved
implementation/src/main/java/io/smallrye/mutiny/helpers/queues/Queues.java
Outdated
Show resolved
Hide resolved
implementation/src/main/java/io/smallrye/mutiny/helpers/queues/Queues.java
Outdated
Show resolved
Hide resolved
implementation/src/main/java/io/smallrye/mutiny/helpers/queues/Queues.java
Outdated
Show resolved
Hide resolved
implementation/src/main/java/io/smallrye/mutiny/helpers/queues/Queues.java
Outdated
Show resolved
Hide resolved
...tation/src/main/java/io/smallrye/mutiny/operators/multi/builders/BufferItemMultiEmitter.java
Show resolved
Hide resolved
...ation/src/main/java/io/smallrye/mutiny/operators/multi/overflow/MultiOnOverflowBufferOp.java
Show resolved
Hide resolved
Work continues in #1413, thanks again @franz1981 |
Replace existing MPSC / SPCS queue implementations by using JCTools