Release CI enhancements after 2.5.0-M1 #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given how unreliable pushing to Maven Central is, we are better off with a release workflow that makes a source release, while another (repeatable) workflow can do the deployment steps. In fact a deployment can fail due to a gateway error while the artifacts actually end up on Maven Central.
cescoffier
approved these changes
Sep 20, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1374 +/- ##
============================================
- Coverage 89.22% 89.16% -0.06%
+ Complexity 3361 3358 -3
============================================
Files 459 459
Lines 13438 13438
Branches 1655 1655
============================================
- Hits 11990 11982 -8
- Misses 807 811 +4
- Partials 641 645 +4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few fixes based on observations of what worked, what didn't, and what can be improved.
We're essentially back to a separate workflow to deploy to Maven Central, given how unreliable the gateway can be.
The deployment of 2.5.0-M1 had failed in CI on the Maven side due to a gateway error, but the artifacts actually made it to Maven Central.