Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: downgrade Java modules support to automatic modules #1415

Closed
wants to merge 2 commits into from
Closed

feat!: downgrade Java modules support to automatic modules #1415

wants to merge 2 commits into from

Conversation

jponge
Copy link
Member

@jponge jponge commented Oct 25, 2023 •
edited
Loading

See #1406

@jponge
feat!: downgrade Java modules support to automatic modules
c99bf1d 
Issue: #1406

BREAKING CHANGE: the Mutiny library is now exposed as an
automatic module rather than a module with a module-info
descriptor.
@jponge jponge force-pushed the feat/jpms-downgrade branch from 15f88bc to c99bf1d Compare October 25, 2023 15:59
@jponge jponge linked an issue Oct 25, 2023 that may be closed by this pull request
Downgrade JPMS support to an automatic module declaration #1406
Closed
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #1415 (e3eb65e) into main (81a2852) will increase coverage by 0.10%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head e3eb65e differs from pull request most recent head 970fb9e. Consider uploading reports for the commit 970fb9e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1415      +/-   ##
============================================
+ Coverage     89.19%   89.29%   +0.10%     
- Complexity     3357     3367      +10     
============================================
  Files           459      459              
  Lines         13438    13438              
  Branches       1655     1655              
============================================
+ Hits          11986    12000      +14     
+ Misses          805      799       -6     
+ Partials        647      639       -8

see 13 files with indirect coverage changes

@jponge
Copy link
Member Author

jponge commented Oct 26, 2023

We won't go this way, we'll either have a JCTools release soon or we will use a fork.

The current JCTools master branch has a correct (generated) module-info that I've been able to test locally.

@jponge jponge closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Downgrade JPMS support to an automatic module declaration
1 participant
@jponge