fix: rewrite of the concatenation operators #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes race conditions in concatMap and stream concatenation operators. Refs: #1388
|
Status: awaiting further tests |
cescoffier
approved these changes
Nov 30, 2023
|
/cc @ozangunalp for some reason you're not part of this org / repo but I'd like your review when you have some bandwidth 😃 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1448 +/- ##
============================================
- Coverage 89.27% 89.27% -0.01%
- Complexity 3363 3366 +3
============================================
Files 459 459
Lines 13454 13403 -51
Branches 1655 1641 -14
============================================
- Hits 12011 11965 -46
+ Misses 802 801 -1
+ Partials 641 637 -4
|
ozangunalp
reviewed
Nov 30, 2023
| if (UPSTREAM_UPDATER.compareAndSet(this, null, s)) { | ||
| public void onSubscribe(Subscription subscription) { | ||
| if (UPSTREAM_UPDATER.compareAndSet(this, null, subscription)) { | ||
| upstream = subscription; |
There was a problem hiding this comment.
Normally you don't need this line, atomic updater sets the field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes race conditions in concatMap and stream concatenation operators.
Refs: #1388