Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass empty contexts rather than null to UniAwait #1458

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

jponge
Copy link
Member

@jponge jponge commented Dec 7, 2023

When no context is specified, Context.empty() must be used rather than null.

Fixes #1457

When no context is specified, Context.empty() must be used rather than null.

Fixes #1457
@jponge jponge added the bug Something isn't working label Dec 7, 2023
@jponge jponge added this to the 2.5.2 milestone Dec 7, 2023
@jponge jponge enabled auto-merge December 7, 2023 08:27
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #1458 (303bdab) into main (5e31dc6) will decrease coverage by 0.32%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1458      +/-   ##
============================================
- Coverage     89.37%   89.06%   -0.32%     
+ Complexity     3364     3352      -12     
============================================
  Files           459      459              
  Lines         13402    13402              
  Branches       1641     1641              
============================================
- Hits          11978    11936      -42     
- Misses          795      824      +29     
- Partials        629      642      +13     
Files Coverage Δ
...java/io/smallrye/mutiny/operators/AbstractUni.java 90.32% <100.00%> (ø)

... and 13 files with indirect coverage changes

@jponge jponge merged commit efc3d0c into main Dec 7, 2023
7 checks passed
@jponge jponge deleted the bug/UniAwait-null-context branch December 7, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UniAwait may not pass null contexts
2 participants