Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a concatMap race condition on inner and outer completions signals #1463

Closed

Conversation

jponge
Copy link
Member

@jponge jponge commented Dec 13, 2023

No description provided.

@jponge
Copy link
Member Author

jponge commented Dec 13, 2023

Doesn't work so far

Avoids a race-condition between the inner and outer subscribers on the
completion signals.
@jponge jponge force-pushed the fix/concatMap-race-on-inner-and-outer-completions branch from 7dbb635 to e179924 Compare December 13, 2023 22:44
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #1463 (e179924) into main (efba606) will increase coverage by 0.23%.
Report is 1 commits behind head on main.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1463      +/-   ##
============================================
+ Coverage     89.12%   89.35%   +0.23%     
- Complexity     3351     3366      +15     
============================================
  Files           459      459              
  Lines         13402    13401       -1     
  Branches       1641     1641              
============================================
+ Hits          11944    11975      +31     
+ Misses          822      795      -27     
+ Partials        636      631       -5     
Files Coverage Δ
...llrye/mutiny/operators/multi/MultiConcatMapOp.java 85.03% <83.33%> (-0.12%) ⬇️

... and 10 files with indirect coverage changes

@jponge
Copy link
Member Author

jponge commented Dec 13, 2023

@ozangunalp You might want to test this on RM 😉

@ozangunalp
Copy link
Collaborator

@jponge you might want to take a break :)

@jponge jponge closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants