Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cancellation issues in Uni to Multi bridge #1521

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Fix cancellation issues in Uni to Multi bridge #1521

merged 3 commits into from
Feb 21, 2024

Conversation

jponge
Copy link
Member

@jponge jponge commented Feb 21, 2024

No description provided.

@jponge jponge linked an issue Feb 21, 2024 that may be closed by this pull request
@jponge jponge requested a review from cescoffier February 21, 2024 16:10
Copy link
Contributor

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'm just concerned by the version change. Is it because you restarted form a tag?

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (2.5.x@bc3ba4f). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             2.5.x    #1521   +/-   ##
========================================
  Coverage         ?   89.39%           
  Complexity       ?     3367           
========================================
  Files            ?      459           
  Lines            ?    13437           
  Branches         ?     1638           
========================================
  Hits             ?    12012           
  Misses           ?      796           
  Partials         ?      629           
Files Coverage Δ
...rye/mutiny/converters/uni/UniToMultiPublisher.java 90.24% <100.00%> (ø)

@jponge
Copy link
Member Author

jponge commented Feb 21, 2024

LGTM - I'm just concerned by the version change. Is it because you restarted form a tag?

Yes, but it's merely cosmetic to be honest, the release workflow will take care of it

@jponge jponge merged commit aeb71fa into 2.5.x Feb 21, 2024
7 checks passed
@jponge jponge deleted the fix/1520 branch February 21, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple onTermination signals when retrying with backoffs
2 participants