-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update creating-uni-pipelines.md #1726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Can you update your commit message to follow the convention? See https://github.com/smallrye/smallrye-mutiny/blob/main/CONTRIBUTING.md#conventional-commits. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1726 +/- ##
============================================
- Coverage 89.44% 89.42% -0.02%
+ Complexity 3271 3270 -1
============================================
Files 457 457
Lines 13301 13317 +16
Branches 1649 1649
============================================
+ Hits 11897 11909 +12
- Misses 789 791 +2
- Partials 615 617 +2 |
@cescoffier I updated the PR message. Maybe you can retrigger the PR checks, since all the others were successful? |
@RapTho I think you didn't push your new message. |
The commit message still does not follow the convention.
|
Added missing verbs and rephrased sentences that didn't make sense. In the `Create-Uni-Pipelines.md`, I found two minor sentences that needed rephrasing. No big deal :)
Thanks! Running the CI again, but it should pass. |
docs: Added missing verb and rephrase sentence that didn't make sense
In the
Create-Uni-Pipelines.md
I found two minor sentences that needed rephrasing. No big deal :)