Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update creating-uni-pipelines.md #1726

Closed
wants to merge 1 commit into from
Closed

Update creating-uni-pipelines.md #1726

wants to merge 1 commit into from

Conversation

RapTho
Copy link

@RapTho RapTho commented Oct 28, 2024

docs: Added missing verb and rephrase sentence that didn't make sense

In the Create-Uni-Pipelines.md I found two minor sentences that needed rephrasing. No big deal :)

Copy link
Contributor

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cescoffier
Copy link
Contributor

Can you update your commit message to follow the convention? See https://github.com/smallrye/smallrye-mutiny/blob/main/CONTRIBUTING.md#conventional-commits.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.42%. Comparing base (9591080) to head (3e43670).
Report is 80 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1726      +/-   ##
============================================
- Coverage     89.44%   89.42%   -0.02%     
+ Complexity     3271     3270       -1     
============================================
  Files           457      457              
  Lines         13301    13317      +16     
  Branches       1649     1649              
============================================
+ Hits          11897    11909      +12     
- Misses          789      791       +2     
- Partials        615      617       +2     

see 10 files with indirect coverage changes

@RapTho
Copy link
Author

RapTho commented Oct 28, 2024

@cescoffier I updated the PR message. Maybe you can retrigger the PR checks, since all the others were successful?

@cescoffier
Copy link
Contributor

@RapTho I think you didn't push your new message.

@cescoffier
Copy link
Contributor

The commit message still does not follow the convention.
It should be:

docs: Update creating-uni-pipelines.md

Added missing verbs and rephrased sentences that didn't make sense
In the `Create-Uni-Pipelines.md`, I found two minor sentences that needed rephrasing. No big deal :)

Added missing verbs and rephrased sentences that didn't make sense. In the `Create-Uni-Pipelines.md`, I found two minor sentences that needed rephrasing. No big deal :)
@cescoffier
Copy link
Contributor

Thanks! Running the CI again, but it should pass.

@RapTho RapTho closed this by deleting the head repository Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants