Rename and improve test for #1565

smallrye · Nov 4, 2023 · 8924d16 · 8924d16
1 parent 3038032
commit 8924d16
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/core/src/test/java/io/smallrye/openapi/runtime/scanner/OpenApiDataObjectScannerTest.java b/core/src/test/java/io/smallrye/openapi/runtime/scanner/OpenApiDataObjectScannerTest.java
@@ -1,6 +1,8 @@
 package io.smallrye.openapi.runtime.scanner;
 
+import static org.junit.jupiter.api.Assertions.assertAll;
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
 
 import java.io.IOException;
 
@@ -44,7 +46,9 @@ void testStreams(String type, Schema.SchemaType itemType, String itemFormat) thr
     }
 
     @Test
-    void testClassWithSchemaTypeString() throws IOException {
+    void testNoSelfReferencingRegardlessOfScanOrder() throws IOException {
+        // one way to trigger issue 1565 (self-referencing) was to have a
+        // non-SchemaType.OBJECT type as a field in another type
         @org.eclipse.microprofile.openapi.annotations.media.Schema(
                 description = "Nested class",
                 type = SchemaType.STRING)
@@ -75,8 +79,10 @@ class C {
         OpenApiDataObjectScanner.process(contextNFirst, nType);
         OpenApiDataObjectScanner.process(contextNFirst, cType);
 
-        assertEquals(
-                contextCFirst.getOpenApi().getComponents().getSchemas().get("1N").getRef(),
-                contextNFirst.getOpenApi().getComponents().getSchemas().get("1N").getRef());
+        assertAll("no self referencing"
+                // the contextCFirst case had "#/components/schemas/1N" from getRef() in smallrye-open-api 3.5.2
+                , () -> assertNull(contextCFirst.getOpenApi().getComponents().getSchemas().get("1N").getRef(), "C first")
+                , () -> assertNull(contextNFirst.getOpenApi().getComponents().getSchemas().get("1N").getRef(), "N first")
+        );
     }
 }