-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maven plugin: index output directory instead of project artifact, logs #1538 (2.3.x backport) #1604
Conversation
smallrye#1538) (backport) Signed-off-by: Michael Edgar <[email protected]> backport
@tuffnatty thank you for the PR. In issue 1436 you mentioned JDK 1.8 compatibility. Recent versions should still be able to execute with Java 8, are you seeing different behavior? We don't run the CI with Java 8 anymore so it's possible some dependency has moved to Java 11 somewhere. |
@MikeEdgar The first problem that I encounter is formatter-maven-plugin, a dependency of smallrye-parent. formatter-maven-plugin's last version supporting JDK 1.8 is 2.16. It was once downgraded from 2.17 to 2.16 in smallrye/smallrye-parent#288, then upgraded to 2.22 in smallrye/smallrye-parent@d813e22 which has been released in smallrye-parent 39. Do you suggest me raising an issue in smallrye-parent instead? Sadly I am totally unfamiliar with the smallrye infrastructure, I am only using your maven-plugin. P.S.: Found the related discussion, where smallrye-parent switches to JDK 11: smallrye/smallrye-parent#376 |
@tuffnatty , for sure JDK 11 is needed to build the plugin for the reasons you mentioned (and possibly others), but what about running it in your project? Do you have a need to build it separately from the released version? |
@MikeEdgar Thank you! Great news! I'm able to run version 3.6.2 of the plugin if I override the following dependencies: <plugin>
<artifactId>smallrye-open-api-maven-plugin</artifactId>
<groupId>io.smallrye</groupId>
<version>3.6.2</version>
<dependencies>
<dependency>
<groupId>io.smallrye.config</groupId>
<artifactId>smallrye-config</artifactId>
<version>2.13.3</version>
</dependency>
<dependency>
<groupId>org.jboss.logging</groupId>
<artifactId>jboss-logging</artifactId>
<version>3.4.3.Final</version>
</dependency>
</dependencies> So my immediate problem is solved, but probably this piece of configuration can be better documented somewhere? |
@tuffnatty , that would be great to add to the plugin's README file following the current simple example. Any interest in doing a PR for that addition? |
@MikeEdgar Done! See #1605. |
Thanks again @tuffnatty . With your other PR merged, are we good to close this as not-needed then? |
@MikeEdgar Thanks! Closing. |
No description provided.