Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven plugin: index output directory instead of project artifact, logs #1538 (2.3.x backport) #1604

Closed
wants to merge 1 commit into from

Conversation

tuffnatty
Copy link
Contributor

No description provided.

@tuffnatty tuffnatty requested a review from a team as a code owner October 8, 2023 20:27
@tuffnatty tuffnatty changed the base branch from main to 2.3.x October 8, 2023 20:28
@MikeEdgar
Copy link
Member

@tuffnatty thank you for the PR. In issue 1436 you mentioned JDK 1.8 compatibility. Recent versions should still be able to execute with Java 8, are you seeing different behavior? We don't run the CI with Java 8 anymore so it's possible some dependency has moved to Java 11 somewhere.

@tuffnatty
Copy link
Contributor Author

tuffnatty commented Oct 9, 2023

@MikeEdgar The first problem that I encounter is formatter-maven-plugin, a dependency of smallrye-parent. formatter-maven-plugin's last version supporting JDK 1.8 is 2.16. It was once downgraded from 2.17 to 2.16 in smallrye/smallrye-parent#288, then upgraded to 2.22 in smallrye/smallrye-parent@d813e22 which has been released in smallrye-parent 39. Do you suggest me raising an issue in smallrye-parent instead? Sadly I am totally unfamiliar with the smallrye infrastructure, I am only using your maven-plugin.

P.S.: Found the related discussion, where smallrye-parent switches to JDK 11: smallrye/smallrye-parent#376

@MikeEdgar
Copy link
Member

@tuffnatty , for sure JDK 11 is needed to build the plugin for the reasons you mentioned (and possibly others), but what about running it in your project? Do you have a need to build it separately from the released version?

@tuffnatty
Copy link
Contributor Author

tuffnatty commented Oct 9, 2023

@MikeEdgar Thank you! Great news! I'm able to run version 3.6.2 of the plugin if I override the following dependencies:

			<plugin>
				<artifactId>smallrye-open-api-maven-plugin</artifactId>
				<groupId>io.smallrye</groupId>
				<version>3.6.2</version>
				<dependencies>
					<dependency>
					    <groupId>io.smallrye.config</groupId>
					    <artifactId>smallrye-config</artifactId>
					    <version>2.13.3</version>
					</dependency>
					<dependency>
						<groupId>org.jboss.logging</groupId>
						<artifactId>jboss-logging</artifactId>
						<version>3.4.3.Final</version>
					</dependency>
                                </dependencies>

So my immediate problem is solved, but probably this piece of configuration can be better documented somewhere?

@MikeEdgar
Copy link
Member

@tuffnatty , that would be great to add to the plugin's README file following the current simple example. Any interest in doing a PR for that addition?

@tuffnatty
Copy link
Contributor Author

@MikeEdgar Done! See #1605.

@MikeEdgar
Copy link
Member

Thanks again @tuffnatty . With your other PR merged, are we good to close this as not-needed then?

@tuffnatty
Copy link
Contributor Author

@MikeEdgar Thanks! Closing.

@tuffnatty tuffnatty closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants