Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test dependency on commons-io #1628

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

MikeEdgar
Copy link
Member

Replaces #1627

One less dependency to think about for a simple file read

@MikeEdgar MikeEdgar added this to the 3.7.1 milestone Oct 26, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! I like PRs that remove dependencies :)

@phillip-kruger phillip-kruger merged commit d9a1d85 into smallrye:main Oct 26, 2023
8 checks passed
@MikeEdgar MikeEdgar deleted the remove-commons-io branch October 26, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants