Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed extra indexing on schema removal #119

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

dogversioning
Copy link
Contributor

This PR removes a second instance of array indexing in the base_table_builder, which was causing us to search only the first character of a potential string for a name like "schema"."table"

This is currently only an issue when we are creating a completely empty table.

Checklist

  • Consider if documentation (like in docs/) needs to be updated
  • Consider if tests should be added
  • Run pylint if you're making changes beyond adding studies
  • Update template repo if there are changes to study configuration

@dogversioning
Copy link
Contributor Author

Since this is affecting sites right now, I'm electing to not write a unit test this second, but am tracking the need for catching this case at #120

@dogversioning dogversioning merged commit 36323e4 into main Sep 6, 2023
3 checks passed
@dogversioning dogversioning deleted the mg/parse_schema_name branch September 6, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants