fix: fix naive timestamps and int types in duckdb #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't require a timezone with our parsed timestamps (otherwise, we can't parse a timestamp like YYYY-MM-DD). And make sure to ask Pandas to use modern nullable columns instead of coerced-float columns when there are nullable-int datasets (like you see if you have a powerset output table with an integer column).
dogversioning
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't require a timezone with our parsed timestamps (otherwise, we can't parse a timestamp like YYYY-MM-DD).
And make sure to ask Pandas to use modern nullable columns instead of coerced-float columns when there are nullable-int datasets (like you see if you have a powerset output table with an integer column).
Checklist
docs/) needs to be updated