Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(duckdb): skip nulls inside array for array_join() #157

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix(duckdb): skip nulls inside array for array_join() #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cumulus_library/databases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,12 @@ def insert_tables(self, tables: dict[str, pyarrow.Table]) -> None:
self.connection.register(name, table)

@staticmethod
def _compat_array_join(value: Optional[list[str]], delimiter: str) -> Optional[str]:
def _compat_array_join(
value: Optional[list[Optional[str]]], delimiter: str
) -> Optional[str]:
if value is None:
return None
return delimiter.join(value)
return delimiter.join(v for v in value if v is not None)

@staticmethod
def _compat_date(
Expand Down