Uprev to 3.10, namespace clarification #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogversioning
commented
Feb 5, 2024
Comment on lines
-35
to
+40
| # TODO: upgrade to 3.10+, use kw_only flag to subclass a dataclass for generating source/target | ||
| code_sources = [ | ||
| CCC(column_name="category", is_array=True, filter_priority=False), | ||
| CCC(column_name="code", is_array=False, filter_priority=False), | ||
| CCC(column_name="interpretation", is_array=True, filter_priority=False), | ||
| CCC(column_name="valuecodeableconcept", is_array=False, filter_priority=False), | ||
| ] | ||
| for source in code_sources: | ||
| source.source_table = "observation" | ||
| source.target_table = f"core__observation_dn_{source.column_name}" | ||
| @dataclass(kw_only=True) | ||
| class ObsConfig(sql_utils.CodeableConceptConfig): | ||
| source_table: str = "observation" | ||
|
|
||
| def __post_init__(self): | ||
| self.target_table = f"core__observation_dn_{self.column_name}" |
There was a problem hiding this comment.
This (and the kw_only addition to the parent class) is the only true functional change in this PR.
I found this article helpful in understanding the why behind this
dogversioning
force-pushed
the
mg/3.11
branch
6 times, most recently
from
80d50b9 to
8a1447e
Compare
dogversioning
force-pushed
the
mg/3.11
branch
from
8a1447e to
26b586b
Compare
mikix
reviewed
Feb 5, 2024
dogversioning
changed the title
dogversioning
force-pushed
the
mg/3.11
branch
from
fc7b43b to
a3b90d2
Compare
mikix
approved these changes
Feb 5, 2024
| python-version: 3.9 | ||
| python-version: '3.10' |
There was a problem hiding this comment.
small point here: we're only testing on 3.10, but as a command line CLI that doesn't ship with its own python in a docker image (i.e. unlike the ETL) - we should probably test on all supported pythons
Doesn't need to happen on this PR - I filed #174 for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
Checklist
docs/) needs to be updated