Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: tighten up core_observation_lab and _vital_signs inclusion #210

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

mikix
Copy link
Contributor

@mikix mikix commented Apr 16, 2024

Require both these observation sub-type tables to use the proper category code and system.

Checklist

  • Consider if documentation (like in docs/) needs to be updated
  • Consider if tests should be added
  • Update template repo if there are changes to study configuration

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A thing I didn't do in this PR, but seems appropriate, is switching core__observation_vital_signs from including valueCodeableConcept fields to valueQuantity fields. I believe quantities are usually used for vital signs, not concepts.

Copy link
Contributor

@dogversioning dogversioning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saying this out loud so it's not just in my head - i think that at some point these two tables should move to a builder, i just didn't get to it due to aforementioned release deadlines.

Require both these observation sub-type tables to use the proper
category code and system.
@mikix
Copy link
Contributor Author

mikix commented Apr 17, 2024

saying this out loud so it's not just in my head - i think that at some point these two tables should move to a builder, i just didn't get to it due to aforementioned release deadlines.

When I add a component table (probably in that same file?), I'll add a comment to that effect.

@mikix mikix merged commit 17b8cd0 into main Apr 17, 2024
3 checks passed
@mikix mikix deleted the mikix/labs-fix branch April 17, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants