Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved upload error reporting #213

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Improved upload error reporting #213

merged 2 commits into from
Apr 18, 2024

Conversation

dogversioning
Copy link
Contributor

This PR makes the following changes:

  • Switches to the builtin response.raise_for_status() function for error generation on rejected uploads for nicer formatting
  • Catches the RequestException gracefully rather than dumping a stack trace

Checklist

  • Consider if documentation (like in docs/) needs to be updated
  • Consider if tests should be added
  • Update template repo if there are changes to study configuration

mikix
mikix approved these changes Apr 18, 2024
View reviewed changes
cumulus_library/cli.py Outdated
upload.upload_files(args)
except requests.RequestException as e:
print(str(e))
exit()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be sys.exit, yeah?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, was just getting to that

@dogversioning dogversioning merged commit 7dedf01 into main Apr 18, 2024
3 checks passed
@dogversioning dogversioning deleted the mg/upload_error_handling branch April 18, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikix mikix mikix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dogversioning @mikix