feat: switch to cumulus-fhir-support's ndjson reading code #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikix
force-pushed
the
mikix/ndjson-parsing
branch
from
4a8411a to
9107941
Compare
mikix
changed the title
dogversioning
approved these changes
Jul 1, 2024
Comment on lines
+14
to
+27
| ## Running tests | ||
|
|
||
| Tests can be run with `pytest` like you might expect, | ||
| but you'll first want to set up a fake `test` AWS profile. | ||
|
|
||
| 1. Edit `~/.aws/credentials` | ||
| 2. Add a block like: | ||
| ``` | ||
| [test] | ||
| aws_access_key_id = test | ||
| aws_secret_access_key = test | ||
| ``` | ||
| 3. Then run `pytest` | ||
|
|
mikix
force-pushed
the
mikix/ndjson-parsing
branch
from
9107941 to
f91a729
Compare
We now load any ndjson files that cumulus-fhir-support says to.
mikix
force-pushed
the
mikix/ndjson-parsing
branch
from
f91a729 to
bb316ed
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now load any ndjson files that cumulus-fhir-support says to.
Depends on smart-on-fhir/cumulus-fhir-support#3
Checklist
docs/) needs to be updated