Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BaseTableBuilder and CountsBuilder to the public API #282

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Add BaseTableBuilder and CountsBuilder to the public API #282

merged 1 commit into from
Aug 20, 2024

Conversation

mikix
Copy link
Contributor

@mikix mikix commented Aug 20, 2024 •
edited
Loading

Checklist

  • Consider if documentation (like in docs/) needs to be updated
  • Consider if tests should be added
  • Update template repo if there are changes to study configuration

@mikix mikix force-pushed the mikix/expose-more branch from ebb7fae to 456916d Compare August 20, 2024 19:29
@mikix mikix marked this pull request as ready for review August 20, 2024 19:29
@mikix mikix force-pushed the mikix/expose-more branch 2 times, most recently from e9b749f to 2f4625f Compare August 20, 2024 19:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 20, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1996 1982 99% 90% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cumulus_library/init.py 100% 🟢
cumulus_library/studies/core/builder_condition.py 100% 🟢
cumulus_library/studies/core/builder_documentreference.py 100% 🟢
cumulus_library/studies/core/builder_encounter.py 100% 🟢
cumulus_library/studies/core/builder_medicationrequest.py 100% 🟢
cumulus_library/studies/core/builder_observation.py 100% 🟢
cumulus_library/studies/core/builder_patient.py 100% 🟢
cumulus_library/studies/core/builder_prereq_tables.py 100% 🟢
cumulus_library/studies/core/count_core.py 100% 🟢
cumulus_library/studies/discovery/code_detection.py 100% 🟢
cumulus_library/studies/vocab/vocab_icd_builder.py 100% 🟢
TOTAL 100% 🟢

updated for commit: d017c26 by action🐍

dogversioning
dogversioning approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@dogversioning dogversioning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh what a good idea

@dogversioning
Copy link
Contributor

PsmBuilder should :probably: also be part of the API, but we can leave that for later

@mikix mikix force-pushed the mikix/expose-more branch from 2f4625f to 36d5058 Compare August 20, 2024 20:02
@mikix mikix force-pushed the mikix/expose-more branch from 36d5058 to d017c26 Compare August 20, 2024 20:02
@mikix mikix merged commit 8525ffd into main Aug 20, 2024
3 checks passed
@mikix mikix deleted the mikix/expose-more branch August 20, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogversioning dogversioning dogversioning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikix @dogversioning