Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove contents of /schemas #284

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Remove contents of /schemas #284

merged 3 commits into from
Aug 21, 2024

Conversation

dogversioning
Copy link
Contributor

@dogversioning dogversioning commented Aug 21, 2024

The remaining artifacts in the schema directory have been unused for awhile now, and may be confusing to new users. This removes them - if we need them for reference, we can always go back to any 2.x tag.

Resolves #283

Checklist

  • Consider if documentation (like in docs/, or if you've changed the structure of a table) needs to be updated
  • Consider if tests should be added
  • Update template repo if there are changes to study configuration

Copy link

github-actions bot commented Aug 21, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1996 1981 99% 90% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 9c00970 by action🐍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're deleting old files, you can probably also delete .pylintrc - but obviously, no rush on that.

@mikix
Copy link
Contributor

mikix commented Aug 21, 2024

Oh also, there is this section of pyproject.toml that can be removed:

# ./cumulus_library/schema needs general revisiting, deferring on style maintenance
# until that occurs
"cumulus_library/schema/valueset.py" = ["E501"]

@dogversioning dogversioning merged commit b8c3f5f into main Aug 21, 2024
3 checks passed
@dogversioning dogversioning deleted the mg/deprecate_schema branch August 21, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove contents of schema dir
2 participants