Skip to content

Commit

Permalink
BOB fixing finality depth in mainnet (#1545)
Browse files Browse the repository at this point in the history
## Motivation
from here
https://chainlink-core.slack.com/archives/C07PS7YS708/p1732062875801939
we are seeing mainnet have a huge discrepancy from our tests results so
bumping the config for BOB regarding finality.

## Solution
  • Loading branch information
fernandezlautaro authored Nov 21, 2024
1 parent 9f39f87 commit 91b07ba
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
8 changes: 4 additions & 4 deletions core/chains/evm/config/toml/defaults/BOB_Mainnet.toml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ChainID = '60808'
# OP stack https://docs.gobob.xyz/learn/introduction/stack-overview#rollup-layer
ChainType = 'optimismBedrock'
# finality_depth was: ~850
FinalityDepth = 900
# FinalityDepth in mainnet showed more than 3k
FinalityDepth = 3150
# block_time was: 2s, adding 1 second buffer
LogPollInterval = '3s'

# finality_depth * block_time / 60 secs = ~30 min (finality time)
NoNewFinalizedHeadsThreshold = '35m'
# finality_depth * block_time / 60 secs = ~105 min (finality time)
NoNewFinalizedHeadsThreshold = '110m'

FinalityTagEnabled = true

Expand Down
8 changes: 4 additions & 4 deletions core/chains/evm/config/toml/defaults/BOB_Testnet.toml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ChainID = '808813'
# OP stack https://docs.gobob.xyz/learn/introduction/stack-overview#rollup-layer
ChainType = 'optimismBedrock'
# finality_depth was: ~850
FinalityDepth = 900
# FinalityDepth in mainnet showed more than 3k
FinalityDepth = 3150
# block_time was: 2s, adding 1 second buffer
LogPollInterval = '3s'

# finality_depth * block_time / 60 secs = ~30 min (finality time)
NoNewFinalizedHeadsThreshold = '35m'
# finality_depth * block_time / 60 secs = ~105 min (finality time)
NoNewFinalizedHeadsThreshold = '110m'

FinalityTagEnabled = true

Expand Down
8 changes: 4 additions & 4 deletions docs/CONFIG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8368,7 +8368,7 @@ AutoCreateKey = true
BlockBackfillDepth = 10
BlockBackfillSkip = false
ChainType = 'optimismBedrock'
FinalityDepth = 900
FinalityDepth = 3150
FinalityTagEnabled = true
LogBackfillBatchSize = 1000
LogPollInterval = '3s'
Expand All @@ -8383,7 +8383,7 @@ LogBroadcasterEnabled = true
RPCDefaultBatchSize = 250
RPCBlockQueryDelay = 1
FinalizedBlockOffset = 0
NoNewFinalizedHeadsThreshold = '35m0s'
NoNewFinalizedHeadsThreshold = '1h50m0s'

[Transactions]
ForwardersEnabled = false
Expand Down Expand Up @@ -9712,7 +9712,7 @@ AutoCreateKey = true
BlockBackfillDepth = 10
BlockBackfillSkip = false
ChainType = 'optimismBedrock'
FinalityDepth = 900
FinalityDepth = 3150
FinalityTagEnabled = true
LogBackfillBatchSize = 1000
LogPollInterval = '3s'
Expand All @@ -9727,7 +9727,7 @@ LogBroadcasterEnabled = true
RPCDefaultBatchSize = 250
RPCBlockQueryDelay = 1
FinalizedBlockOffset = 0
NoNewFinalizedHeadsThreshold = '35m0s'
NoNewFinalizedHeadsThreshold = '1h50m0s'

[Transactions]
ForwardersEnabled = false
Expand Down

0 comments on commit 91b07ba

Please sign in to comment.