LogPoller support for MaxLogsKept #1338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reductionista
changed the title
reductionista
changed the title
reductionista
changed the title
reductionista
force-pushed
the
max-logs-kept-tests
branch
from
ca7b2d5 to
738ef14
Compare
reductionista
force-pushed
the
max-logs-kept-tests
branch
from
738ef14 to
a050b2e
Compare
reductionista
changed the title
reductionista
force-pushed
the
max-logs-kept-tests
branch
from
3101bcf to
33ad38b
Compare
reductionista
force-pushed
the
max-logs-kept-tests
branch
from
33ad38b to
707c330
Compare
reductionista
force-pushed
the
max-logs-kept-tests
branch
from
814b898 to
0a76672
Compare
Also, remove some extraneous lines in orm_test.go
- Remove topics from SelectExcessLogs query - Early exit from loadFilters - upper >= end
reductionista
force-pushed
the
max-logs-kept-tests
branch
from
e33f9cc to
2500099
Compare
|
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR was closed because it has been stalled for 10 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Presently, LogPoller supports only time-based retention, via the Retention field in the filters passed to
RegisterFilter. TheMaxLogsKeptfield was added earlier in anticipation of the need for also supporting recency-count based retention. One example of a case where time based retention is risky is theTransmitevent in the OCR Contract Transmitter. No matter how long the retention period is set to, there's a chance the node will be down for longer than that, and miss logs when it comes back up. This would make a bad situation even worse, because the transmit event would never be picked up at all.Solution
This implements the MaxLogsKept feature in LogPoller. When specified, this field tells LogPoller it's okay to prune logs matching a filter if there are at least
MaxLogsKeptmore recent matching logs in the db.In the example above, this avoid storing any more logs than needed while always having the latest transmit event available. In this case, older transmit events are no longer relevant if there is a more recent one.
In general, this should be just as useful for anything accessed only via ChainReader's
GetLatestValue()method rather thanQueryKey().A log may be pruned either because it's too old in terms of time or in terms of the number of logs being saved. It need not satisfy both the
RetentionandMaxLogsKeptcriteria in order to get pruned.