Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Generalised Headtracker Components #123

Closed
wants to merge 16 commits into from
Closed

Added Generalised Headtracker Components #123

wants to merge 16 commits into from

Conversation

yongkangc
Copy link
Contributor

@yongkangc yongkangc commented Jun 6, 2023 •
edited
Loading

Context

This PR moves over the Generalised HeadTracker components from core common/types repo to the chainlink-relay repo. This allows chain specific repositories to make use of the generalised Headtracker interfaces.

Changes

  • Moved over files from common/types
  • Added mock files

Note:

  • It is likely that we would have to move over the concrete types and methods for head tracker services - listener, broadcaster, and tracker. That would be in a separate PR.

Ticket: https://smartcontract-it.atlassian.net/jira/software/c/projects/BCI/boards/23?modal=detail&selectedIssue=BCI-1116&assignee=712020%3A94dec959-6ba0-490a-b977-351d09b34915

@yongkangc yongkangc temporarily deployed to integration June 6, 2023 21:58 — with GitHub Actions Inactive
@yongkangc yongkangc requested a review from aalu1418 June 6, 2023 22:00
@yongkangc yongkangc marked this pull request as ready for review June 6, 2023 22:00
@yongkangc yongkangc temporarily deployed to integration June 6, 2023 22:06 — with GitHub Actions Inactive
jmank88
jmank88 reviewed Jun 6, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
jmank88
jmank88 previously approved these changes Jun 6, 2023
View reviewed changes
@yongkangc yongkangc temporarily deployed to integration June 6, 2023 22:34 — with GitHub Actions Inactive
prashantkumar1982
prashantkumar1982 reviewed Jun 6, 2023
View reviewed changes
Copy link

@prashantkumar1982 prashantkumar1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to wait on this, till you finish all those changes in the other PR that I commented on?
We can move repos once all changes are fully finished.

@yongkangc
Copy link
Contributor Author

yongkangc commented Jun 7, 2023 •
edited
Loading

Is it possible to wait on this, till you finish all those changes in the other PR that I commented on?
We can move repos once all changes are fully finished.

This PR will be pending until the other issues are addressed in the ticket are done

https://smartcontract-it.atlassian.net/jira/software/c/projects/BCI/boards/23?modal=detail&assignee=712020%3A94dec959-6ba0-490a-b977-351d09b34915

@yongkangc yongkangc changed the title Added Generalised Headtracker Components Added Generalised Headtracker Components [Draft - Pending changes from Core] Jun 7, 2023
@yongkangc yongkangc marked this pull request as draft June 7, 2023 18:04
@yongkangc yongkangc temporarily deployed to integration June 21, 2023 18:42 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration June 21, 2023 18:42 — with GitHub Actions Inactive
@yongkangc
Copy link
Contributor Author

All the changes have been moved to this repo, ready for review

@yongkangc yongkangc temporarily deployed to integration June 22, 2023 18:02 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration June 22, 2023 18:02 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration June 22, 2023 18:02 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration June 22, 2023 18:40 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration June 22, 2023 18:40 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration June 22, 2023 18:40 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration June 23, 2023 00:15 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration June 23, 2023 00:15 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration June 23, 2023 00:15 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration June 23, 2023 02:51 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration June 23, 2023 02:51 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration June 23, 2023 02:51 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration June 23, 2023 22:26 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration June 23, 2023 22:26 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration June 23, 2023 22:26 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration July 14, 2023 16:24 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration July 14, 2023 16:24 — with GitHub Actions Inactive
@yongkangc yongkangc temporarily deployed to integration July 14, 2023 16:24 — with GitHub Actions Inactive
@yongkangc yongkangc mentioned this pull request Jul 14, 2023
Closed
@yongkangc yongkangc closed this Jul 14, 2023
@yongkangc
Copy link
Contributor Author

Closed PR. Created another updated one

#139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashantkumar1982 prashantkumar1982 prashantkumar1982 left review comments

@jmank88 jmank88 jmank88 left review comments

@aalu1418 aalu1418 Awaiting requested review from aalu1418

@krebernisak krebernisak Awaiting requested review from krebernisak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yongkangc @jmank88 @prashantkumar1982