Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DataSource to ChainOpts and pass to NewChain #916

Merged
merged 17 commits into from
Nov 27, 2024
Merged

Add DataSource to ChainOpts and pass to NewChain #916

merged 17 commits into from
Nov 27, 2024

Conversation

reductionista
Copy link
Contributor

@reductionista reductionista commented Nov 6, 2024 •
edited
Loading

Description

Requires Dependencies

Resolves Dependencies

core ref: 7b0c8369f2ae3a9a7fdf0eb490a6ae877b5d9540

@reductionista reductionista mentioned this pull request Nov 6, 2024
Merged
@reductionista reductionista mentioned this pull request Nov 6, 2024
Merged
@jmank88 jmank88 requested a review from chainchad November 26, 2024 13:05
@jmank88
Copy link
Contributor

jmank88 commented Nov 26, 2024

(If these changes don't make sense, happy to undo them I just figured since we're setting it to 1.23.3 and GOTOOLCHAIN everywhere else we may as well here.)

auto is the default, so it would be cleaner to only set it when necessary.

hendoxc
hendoxc previously approved these changes Nov 26, 2024
View reviewed changes
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@aalu1418 aalu1418 merged commit 3c9282e into develop Nov 27, 2024
34 of 35 checks passed
@aalu1418 aalu1418 deleted the NONEVM-694/db-support branch November 27, 2024 20:11
dhaidashenko pushed a commit that referenced this pull request Dec 20, 2024
@reductionista @dhaidashenko
Add DataSource to ChainOpts and pass to NewChain (#916)
d7f647b 
* Add DataSource to ChainOpts and pass to newChain

* Remove extra NewDataSource arg

* Use sqltest.NewNoOpDataSource()

* sqltest -> sqlutil/sqltest

* Update go.mod

* Fix imports & add replace block to go.mod

* Update chainlink refs in go.mod

* Add souregraph replace

* Fix order of imports

* GOTOOLCHAIN=auto

* Update Dockerifle & .tool-versions to golang 1.23

* Update chainlink-testing-framework to v1.50.16

Also add ENV GOTOOLFILE=auto to docker image, this might help it
work next time even if we haven't updated chainlink-testing-framework yet

* Remove setting of GOTOOLCHAIN=auto from workflow

* Update chainlink ref in integration-tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalu1418 aalu1418 aalu1418 approved these changes

@jmank88 jmank88 jmank88 approved these changes

@hendoxc hendoxc hendoxc left review comments

@dhaidashenko dhaidashenko dhaidashenko left review comments

@chainchad chainchad Awaiting requested review from chainchad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@reductionista @jmank88 @dhaidashenko @hendoxc @aalu1418 @chainchad