logs are forwarded to a processor in slot and trx order #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EasterTheBunny
had a problem deploying
to
integration
GitHub Actions
Error
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
had a problem deploying
to
integration
GitHub Actions
Error
EasterTheBunny
force-pushed
the
etb/ordered-log-processing
branch
from
094f9cb to
72089b2
Compare
EasterTheBunny
had a problem deploying
to
integration
GitHub Actions
Failure
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
had a problem deploying
to
integration
GitHub Actions
Failure
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
force-pushed
the
etb/ordered-log-processing
branch
from
f407d8f to
f9824d9
Compare
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
force-pushed
the
etb/ordered-log-processing
branch
from
f9824d9 to
376697e
Compare
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
pkg/solana/logpoller/loader.go
Outdated
|
|
||
| func (p *orderedParser) sendReadySlots() error { | ||
| // start at the lowest block and find ready blocks | ||
| for element := p.blocks.Front(); element != nil; element = element.Next() { |
There was a problem hiding this comment.
Suggested change
| for element := p.blocks.Front(); element != nil; element = element.Next() { | |
| for element := p.blocks.Front(); element != nil; element = p.blocks.Front() { |
To drop
temp := element.Prev()
if temp == nil {
break
}
element = temp
There was a problem hiding this comment.
Also due to break, there is a leak of expectations.
There was a problem hiding this comment.
Ahh ok. I was just using the iteration method in the docs. This works better. Thanks
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
dhaidashenko
approved these changes
Dec 18, 2024
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
reductionista
approved these changes
Dec 19, 2024
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
GitHub Actions
Inactive
|
dhaidashenko
pushed a commit
that referenced
this pull request
Dec 20, 2024
* logs are forwarded to a processor in slot and trx order * make tests pass again * simplify block and expectation ordering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Log ingestion heavily leverages async go-routines but
LogPollerwill rely on logs delivered in slot/block order. This commit adds a new component to the log ingestion to order logs before forwarding them toLogPoller.