Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create instructions codec #954

Merged
merged 2 commits into from
Dec 10, 2024
Merged

create instructions codec #954

merged 2 commits into from
Dec 10, 2024

Conversation

EasterTheBunny
Copy link
Contributor

Description

This commit adds a constructor for a codec that targets instruction args.

@EasterTheBunny EasterTheBunny requested a review from a team as a code owner December 2, 2024 17:40
reductionista
reductionista approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@reductionista reductionista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much context on this, but LGTM

@aalu1418 aalu1418 enabled auto-merge (squash) December 10, 2024 15:54
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@aalu1418 aalu1418 merged commit b4fae73 into develop Dec 10, 2024
34 of 35 checks passed
@aalu1418 aalu1418 deleted the etb/instructions-codec branch December 10, 2024 16:50
dhaidashenko pushed a commit that referenced this pull request Dec 20, 2024
@EasterTheBunny @dhaidashenko
create instructions codec (#954)
0b3993e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalu1418 aalu1418 aalu1418 approved these changes

@silaslenihan silaslenihan silaslenihan approved these changes

@reductionista reductionista reductionista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EasterTheBunny @reductionista @silaslenihan @aalu1418