Add more detail to pipeline run failure errors

smartcontractkit · Nov 19, 2024 · 2636441 · 2636441
1 parent cf277b8
commit 2636441
Showing 1 changed file with 15 additions and 8 deletions.
diff --git a/core/services/pipeline/runner.go b/core/services/pipeline/runner.go
@@ -510,14 +510,21 @@ func (r *runner) run(ctx context.Context, pipeline *Pipeline, run *Run, vars Var
 		)
 	}
 	l = l.With("run.State", run.State, "fatal", run.HasFatalErrors(), "runTime", runTime)
-	if run.HasFatalErrors() {
-		// This will also log at error level in OCR if it fails Observe so the
-		// level is appropriate
-		l = l.With("run.FatalErrors", run.FatalErrors)
-		l.Debugw("Completed pipeline run with fatal errors")
-	} else if run.HasErrors() {
-		l = l.With("run.AllErrors", run.AllErrors)
-		l.Debugw("Completed pipeline run with errors")
+	if run.HasFatalErrors() || run.HasErrors() {
+		var errorsWithID []string
+		for _, taskRun := range run.PipelineTaskRuns {
+			if taskRun.Error.Valid {
+				err := fmt.Sprintf("%s(%s); %s", taskRun.DotID, taskRun.Type, taskRun.Error.ValueOrZero())
+				errorsWithID = append(errorsWithID, err)
+			}
+		}
+		if run.HasFatalErrors() {
+			l = l.With("run.FatalErrors", run.FatalErrors)
+			l.Debugw("Completed pipeline run with fatal errors")
+		} else if run.HasErrors() {
+			l = l.With("run.AllErrors", run.AllErrors)
+			l.Debugw("Completed pipeline run with errors")
+		}
 	} else if r.config.VerboseLogging() {
 		l.Debugw("Completed pipeline run successfully")
 	}