Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Functions] Add extra expiration check in storage plugin #10805

Merged
merged 2 commits into from
Sep 26, 2023
Merged

[Functions] Add extra expiration check in storage plugin #10805

merged 2 commits into from
Sep 26, 2023

Conversation

bolekk
Copy link
Contributor

@bolekk bolekk commented Sep 26, 2023

No description provided.

@github-actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

KuphJr
KuphJr previously approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@KuphJr KuphJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a test?

@bolekk bolekk enabled auto-merge September 26, 2023 22:49
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@bolekk bolekk added this pull request to the merge queue Sep 26, 2023
Merged via the queue into develop with commit f67d7e3 Sep 26, 2023
81 of 82 checks passed
@bolekk bolekk deleted the s4_checks branch September 26, 2023 23:15
bolekk added a commit that referenced this pull request Sep 27, 2023
@bolekk
[Functions] Add extra expiration check in storage plugin (#10805)
e2cf3ec
@snehaagni snehaagni mentioned this pull request Nov 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KuphJr KuphJr KuphJr approved these changes

@pinebit pinebit Awaiting requested review from pinebit

@justinkaseman justinkaseman Awaiting requested review from justinkaseman

@jmank88 jmank88 Awaiting requested review from jmank88

@krehermann krehermann Awaiting requested review from krehermann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bolekk @KuphJr