BCF-2901 Fix potential JAID collisions in multi chain env #11821
Conversation
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
ilija42
force-pushed
the
fix-eth-keys-list
branch
from
26fde61 to
6d70c8e
Compare
ilija42
force-pushed
the
fix-eth-keys-list
branch
from
6d70c8e to
224e9f7
Compare
ilija42
force-pushed
the
fix-eth-keys-list
branch
from
224e9f7 to
d8933be
Compare
ilija42
force-pushed
the
fix-eth-keys-list
branch
from
d8933be to
2f644d3
Compare
ilija42
changed the title
ilija42
force-pushed
the
fix-eth-keys-list
branch
from
496962e to
d5c70e7
Compare
This fixes some rest api responses getting omitted when the JAID was same across multiple chains
ilija42
force-pushed
the
fix-eth-keys-list
branch
from
d5c70e7 to
729defc
Compare
# Conflicts: # integration-tests/actions/vrf/vrfv2plus/vrfv2plus_steps.go # integration-tests/actions/vrfv2_actions/vrfv2_steps.go
core/internal/cltest/cltest.go
Outdated
| func FormatWithPrefixedChainID(id, chainID string) string { | ||
| return fmt.Sprintf("%s/%s", chainID, id) |
There was a problem hiding this comment.
This is kind of hard to read, and the opposite order could be surprising.
WDYT about inlining these cases? I think it will be less characters than this func name, and you can drop some explicit .String() calls too.
There was a problem hiding this comment.
Flipped the params, but not sure about inline. I feel like this stands out more and is less likely to make someone scratch their head if some test results needs to be prefixed. Although this is very simple so may not be an issue idk
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This fixes some rest api responses getting omitted when the JAID was same across multiple chains