CCIP-3414: Make gas fee staleness threshold configurable per chain (#1491) #14734

RyanRHall · 2024-10-11T13:59:38Z

Cherry-pick of this PR
On some chains, it is possible the gas price will just always be zero or will be fixed at some constant fee. Make stalenessThreshold per dest chain and have 0 mean no staleness check.

github-actions · 2024-10-11T14:01:28Z

Below is an analysis created by an LLM. Be mindful of hallucinations and verify accuracy.

WF: CI Core#7cb01cb

Error 1: Undefined Field in FeeQuoterStaticConfig

Source of Error:

##[error]deployment/ccip/view/v1_6/feequoter.go:83:36: staticConfig.StalenessThreshold undefined (type fee_quoter.FeeQuoterStaticConfig has no field or method StalenessThreshold)

Why:
The error indicates that the StalenessThreshold field or method does not exist in the FeeQuoterStaticConfig type within the feequoter.go file. This could be due to a typo, a missing implementation, or an outdated reference in the codebase.

Suggested fix:
Review the FeeQuoterStaticConfig definition to confirm if StalenessThreshold should be a part of it. If it should, add the missing field or method. If not, remove or update the reference in feequoter.go to align with the current structure of FeeQuoterStaticConfig.

Error 2: Process Completed with Exit Code 1

Source of Error:

##[error]Process completed with exit code 1.

Why:
This error typically indicates that the program terminated with an error state, which in this context is likely due to the previously mentioned compilation error in the Go code.

Suggested fix:
Resolve the compilation error detailed in Error 1. Ensure that all unit tests pass and that there are no compile-time errors in the code before rerunning the workflow. This should help the process exit with a successful code.

github-actions · 2024-10-11T15:16:11Z

WF: CI Core#bc8695b

No errors found in this run. 🎉

github-actions · 2024-10-11T15:31:42Z

Below is an analysis created by an LLM. Be mindful of hallucinations and verify accuracy.

WF: CI Core#bd4ce26

Error: Unknown Field in Struct Literal

Source of Error:

##[error]deployment/ccip/deploy.go:550:6: unknown field StalenessThreshold in struct literal of type fee_quoter.FeeQuoterStaticConfig

Why:
The error indicates that the StalenessThreshold field does not exist in the FeeQuoterStaticConfig struct. This could be due to a typo, a recent change in the struct definition, or the field being deprecated or renamed.

Suggested fix:
Check the definition of FeeQuoterStaticConfig in the relevant Go package to confirm the available fields. If StalenessThreshold has been renamed or removed, update the code to use the correct field name or handle the logic differently if the field is deprecated. If it's a typo, correct it to match the intended field name.

github-actions · 2024-10-15T14:26:00Z

Solidity Review Jira issue

Hey! We have taken the liberty to link this PR to a Jira issue for Solidity Review.

This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one.
Please reach out to the Test Tooling team and notify them about any issues you encounter.

Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: contracts/.changeset/tricky-cups-hammer.md

This PR has been linked to Solidity Review Jira issue:

github-actions · 2024-10-15T14:26:44Z

WF: CI Core#4939394

No errors found in this run. 🎉

github-actions · 2024-10-15T14:33:24Z

Below is an analysis created by an LLM. Be mindful of hallucinations and verify accuracy.

WF: CI Core#c5205c2

1. HTTP 503 Service Temporarily Unavailable error during push request:Flakey Test Detection

Source of Error:

Flakey Test Detection	Re-run tests	2024-10-16T14:31:34.9644495Z 2024/10/16 14:31:34 Error re-running flakey tests: push request failed: status=503, body=<html>
Flakey Test Detection	Re-run tests	2024-10-16T14:31:34.9646642Z <head><title>503 Service Temporarily Unavailable</title></head>
Flakey Test Detection	Re-run tests	2024-10-16T14:31:34.9647703Z <body>
Flakey Test Detection	Re-run tests	2024-10-16T14:31:34.9648621Z <center><h1>503 Service Temporarily Unavailable</h1></center>
Flakey Test Detection	Re-run tests	2024-10-16T14:31:34.9649677Z <hr><center>nginx</center>
Flakey Test Detection	Re-run tests	2024-10-16T14:31:34.9650329Z </body>
Flakey Test Detection	Re-run tests	2024-10-16T14:31:34.9651221Z </html>
Flakey Test Detection	Re-run tests	2024-10-16T14:31:34.9668185Z ##[error]Process completed with exit code 1.

Why: The error occurred because the service that the GitHub Action was trying to push a request to was temporarily unavailable, likely due to server issues or maintenance.

Suggested fix: Implement retry logic with exponential backoff in the GitHub Action to handle temporary unavailability of external services. Alternatively, check the service status and ensure it's available before attempting requests.

On some chains, it is possible the gas price will just always be zero or will be fixed at some constant fee Make stalenessThreshold per dest chain and have 0 mean no staleness check

…d-changes

github-actions · 2024-10-16T15:08:45Z

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

…d-changes

cl-sonarqube-production · 2024-10-16T19:49:24Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

RyanRHall requested review from RensR, matYang, RayXpub, elatoskinas and a team as code owners October 11, 2024 13:59

RyanRHall requested a review from cedric-cordenier October 11, 2024 13:59

RyanRHall force-pushed the cherry-pick-fee-quoter-staleness-threshold-changes branch from bc8695b to ba02b5f Compare October 11, 2024 15:15

RyanRHall requested a review from a team as a code owner October 11, 2024 15:29

RyanRHall changed the title ~~Make gas fee staleness threshold configurable per chain (#1491)~~ CCIP-3414: Make gas fee staleness threshold configurable per chain (#1491) Oct 11, 2024

RyanRHall force-pushed the cherry-pick-fee-quoter-staleness-threshold-changes branch from bd4ce26 to 136febb Compare October 15, 2024 14:24

RyanRHall requested review from jhweintraub and 0xsuryansh as code owners October 15, 2024 14:24

RyanRHall force-pushed the cherry-pick-fee-quoter-staleness-threshold-changes branch from 0cbcb43 to 4939394 Compare October 15, 2024 14:31

RyanRHall enabled auto-merge October 15, 2024 15:40

RyanRHall and others added 6 commits October 15, 2024 13:30

Make gas fee staleness threshold configurable per chain (#1491)

4a20e5b

On some chains, it is possible the gas price will just always be zero or will be fixed at some constant fee Make stalenessThreshold per dest chain and have 0 mean no staleness check

add changeset

af7416d

fix offchain code

77484c5

update structs in integration-tests

efe579a

update core changeset

b7f1e72

[Bot] Update changeset file with jira issues

815b445

RyanRHall force-pushed the cherry-pick-fee-quoter-staleness-threshold-changes branch from ceaf096 to 8506e22 Compare October 15, 2024 18:24

update snapshot & wrapper

c5205c2

RyanRHall force-pushed the cherry-pick-fee-quoter-staleness-threshold-changes branch from 8506e22 to c5205c2 Compare October 15, 2024 18:38

RensR approved these changes Oct 16, 2024

View reviewed changes

0xsuryansh approved these changes Oct 16, 2024

View reviewed changes

Merge branch 'develop' into cherry-pick-fee-quoter-staleness-threshol…

511fd0c

…d-changes

RyanRHall added 2 commits October 16, 2024 11:42

Merge branch 'develop' into cherry-pick-fee-quoter-staleness-threshol…

d8a6425

…d-changes

Merge branch 'develop' into cherry-pick-fee-quoter-staleness-threshol…

1812c17

…d-changes

jmank88 approved these changes Oct 16, 2024

View reviewed changes

RyanRHall added this pull request to the merge queue Oct 16, 2024

samsondav approved these changes Oct 16, 2024

View reviewed changes

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2024

RyanRHall added this pull request to the merge queue Oct 16, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2024

RyanRHall added this pull request to the merge queue Oct 16, 2024

Merged via the queue into develop with commit ca71878 Oct 16, 2024
167 checks passed

RyanRHall deleted the cherry-pick-fee-quoter-staleness-threshold-changes branch October 16, 2024 20:59

github-actions bot mentioned this pull request Oct 16, 2024

[DO NOT MERGE] Changeset Release Preview - v2.19.0 #13148

Draft

timweri restored the cherry-pick-fee-quoter-staleness-threshold-changes branch October 21, 2024 13:35

This was referenced Oct 21, 2024

[DO NOT MERGE] Changeset Release Preview - v2.19.0 philipjonsen/chainlink#2

Draft

[DO NOT MERGE] Changeset Release Preview - v2.18.0 picoinnetwork/chainlink#1

Draft

[DO NOT MERGE] Changeset Release Preview - v2.18.0 fanligroup/chainlink#1

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CCIP-3414: Make gas fee staleness threshold configurable per chain (#1491) #14734

CCIP-3414: Make gas fee staleness threshold configurable per chain (#1491) #14734

RyanRHall commented Oct 11, 2024

github-actions bot commented Oct 11, 2024 •

edited

Loading

github-actions bot commented Oct 11, 2024 •

edited

Loading

github-actions bot commented Oct 11, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024

github-actions bot commented Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 16, 2024 •

edited

Loading

cl-sonarqube-production bot commented Oct 16, 2024

CCIP-3414: Make gas fee staleness threshold configurable per chain (#1491) #14734

CCIP-3414: Make gas fee staleness threshold configurable per chain (#1491) #14734

Conversation

RyanRHall commented Oct 11, 2024

github-actions bot commented Oct 11, 2024 • edited Loading

WF: CI Core#7cb01cb

Error 1: Undefined Field in FeeQuoterStaticConfig

Error 2: Process Completed with Exit Code 1

github-actions bot commented Oct 11, 2024 • edited Loading

WF: CI Core#bc8695b

github-actions bot commented Oct 11, 2024 • edited Loading

WF: CI Core#bd4ce26

Error: Unknown Field in Struct Literal

github-actions bot commented Oct 15, 2024

Solidity Review Jira issue

github-actions bot commented Oct 15, 2024 • edited Loading

WF: CI Core#4939394

github-actions bot commented Oct 15, 2024 • edited Loading

WF: CI Core#c5205c2

1. HTTP 503 Service Temporarily Unavailable error during push request:Flakey Test Detection

github-actions bot commented Oct 16, 2024 • edited Loading

AER Report: CI Core ran successfully ✅

AER Report: Operator UI CI ran successfully ✅

cl-sonarqube-production bot commented Oct 16, 2024

Quality Gate passed

github-actions bot commented Oct 11, 2024 •

edited

Loading

github-actions bot commented Oct 11, 2024 •

edited

Loading

github-actions bot commented Oct 11, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 16, 2024 •

edited

Loading