refactor(registrysyncer): tests clean up

[MStreet3]

minor cleanup changes to registrysyncer tests

Requires

Resolves

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
1 Fixed issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

[github-actions]

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , lint , Core Tests (go_core_tests) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , SonarQube Scan , Flakey Test Detection

1. Race condition detected:[Run tests]

Source of Error:

Run tests	2024-10-25T23:18:03.0841328Z + echo 'Race(s) detected'
Run tests	2024-10-25T23:18:03.0841856Z Race(s) detected
Run tests	2024-10-25T23:18:03.0847933Z + exit 1
Run tests	2024-10-25T23:18:03.0861740Z ##[error]Process completed with exit code 1.

Why: The error indicates that a race condition was detected during the execution of the Go tests. Race conditions occur when multiple threads or processes access shared data concurrently, and at least one of them modifies it, leading to unpredictable behavior.

Suggested fix: Use Go's race detector to identify and fix the race conditions in the code. Ensure proper synchronization mechanisms like mutexes or channels are used to manage concurrent access to shared resources.