Cappl 3 ph

[patrickhuie19]

Requires

Supports

[github-actions]

Static analysis results are available

Hey @cedric-cordenier, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

[github-actions]

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Deployment Project , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/job, ubuntu-latest) , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/standardcapabilities, ubuntu-la... , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/workflows, ubuntu-latest) , Flakey Test Detection , SonarQube Scan , Flakeguard Root Project / Report

1. Redeclared variables in test file: [Run tests with flakeguard]

Source of Error:

core/services/standardcapabilities/standard_capabilities_test.go:10:2: require redeclared in this block
core/services/standardcapabilities/standard_capabilities_test.go:8:2: other declaration of require
core/services/standardcapabilities/standard_capabilities_test.go:10:2: "github.com/test-go/testify/require" imported and not used
core/services/standardcapabilities/standard_capabilities_test.go:20:2: logger redeclared in this block
core/services/standardcapabilities/standard_capabilities_test.go:17:2: other declaration of logger
core/services/standardcapabilities/standard_capabilities_test.go:20:2: "github.com/smartcontractkit/chainlink/v2/core/logger" imported and not used
core/services/standardcapabilities/standard_capabilities_test.go:21:2: job redeclared in this block
core/services/standardcapabilities/standard_capabilities_test.go:18:2: other declaration of job
core/services/standardcapabilities/standard_capabilities_test.go:21:2: "github.com/smartcontractkit/chainlink/v2/core/services/job" imported and not used

Why: The test file standard_capabilities_test.go has multiple redeclarations of variables (require, logger, job) and unused imports, causing compilation errors.

Suggested fix: Remove the redundant declarations and ensure each variable is declared only once. Also, remove any unused imports.

2. fmt.Printf format error: [Run tests]

Source of Error:

core/services/gateway/handlers/capabilities/handler.go:79:2: fmt.Printf format %d reads arg #2, but call has 1 arg

Why: The fmt.Printf function call expects two arguments for the format string %d, but only one argument is provided.

Suggested fix: Ensure that the number of arguments matches the format specifiers in the fmt.Printf call.

3. Replacement transaction underpriced: [Run tests]

Source of Error:

integration_test.go:96: 
	Error Trace:	/home/runner/work/chainlink/chainlink/core/services/transmission/integration_test.go:96
	 				/home/runner/work/chainlink/chainlink/core/services/transmission/integration_test.go:223
	Error: 	Received unexpected error:
	 	replacement transaction underpriced
	Test: 	Test4337WithLinkTokenPaymaster

Why: The error indicates that a replacement transaction was attempted with a gas price lower than the original transaction, which is not allowed.

Suggested fix: Increase the gas price for the replacement transaction to be higher than the original transaction's gas price.

4. CSA key does not exist: [Run tests with flakeguard]

Source of Error:

chainlink/application.go:711	[Feeds Service] Failed to start CSA key does not exist

Why: The Feeds Service failed to start because the required CSA key is missing.

Suggested fix: Ensure that the CSA key is generated and available before starting the Feeds Service.

5. SQL transaction aborted: [Run tests with flakeguard]

Source of Error:

EVM.0.Txm.Reaper	txmgr/reaper.go:79	unable to reap old txes: TxmReaper#reapEthTxes batch delete of finalized evm.txes failed: ReapTxes failed to delete old finalized evm.txes: ERROR: current transaction is aborted, commands ignored until end of transaction block (SQLSTATE 25P02)

Why: The SQL transaction was aborted, causing subsequent commands to be ignored.

Suggested fix: Investigate the cause of the transaction abort and ensure that the transaction is properly handled or retried.

6. Post request EOF error: [Run tests with flakeguard]

Source of Error:

cltest.go:778: 
	Error Trace:	/home/runner/work/chainlink/chainlink/core/internal/cltest/cltest.go:799
	 				/home/runner/work/chainlink/chainlink/core/internal/cltest/cltest.go:778
	 				/home/runner/work/chainlink/chainlink/core/internal/cltest/cltest.go:952
	 				/home/runner/work/chainlink/chainlink/core/services/job/runner_integration_test.go:1004
	Error: 	Received unexpected error:
	 	Post "http://127.0.0.1:38759/v2/external_initiators": EOF
	Test: 	TestRunner_Error_Callback_AsyncJob

Why: The POST request to the external initiator endpoint failed with an EOF error, indicating a premature end of the response.

Suggested fix: Ensure the external initiator service is running and accessible. Check for network issues or service crashes that might cause the EOF error.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

[github-actions]

Flaky Test Detector for ./go.mod project has failed ❌

Ran new or updated tests between develop and 2744b82 (CAPPL-3-ph).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 51 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                             TestName                                     PassRatio  RunCount   Skipped
---------                                                               ---------                                    ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/services/workflows/store  Test_StoreDB_GetUnfinishedSteps              0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_GracefulEarlyTermination          0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_GetsNodeInfoDuringInitialization  0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_TimesOutOldExecutions             0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_MultiStepDependencies             0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_ResumesPendingExecutions          0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestEngine_WrapsTargets                      0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestRetryableSuccessAfterRetries             0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows        TestRetryableErrorAfterMultipleRetries       0%         1          false