Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INFOPLAT-1468 Enable batching for beholder emitter #15173

Merged
merged 10 commits into from
Nov 11, 2024

Conversation

pkcll
Copy link
Contributor

@pkcll pkcll commented Nov 8, 2024

Enable batching for beholder emitter
This is needed to make Emitter.Emit non blocking if otel-collector is not available

Context
https://smartcontract-it.atlassian.net/browse/INFOPLAT-1468

@pkcll pkcll requested review from 4of9 and jmank88 November 8, 2024 20:22
Copy link
Contributor

github-actions bot commented Nov 8, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@pkcll pkcll changed the title Enable batching for beholder emitter INFOPLAT-1468 Enable batching for beholder emitter Nov 8, 2024
@pkcll pkcll requested a review from patrickhuie19 November 8, 2024 20:26
Copy link
Contributor

github-actions bot commented Nov 8, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@pkcll pkcll marked this pull request as ready for review November 8, 2024 21:10
@pkcll pkcll requested review from a team as code owners November 8, 2024 21:10
jmank88
jmank88 previously approved these changes Nov 8, 2024
@pkcll pkcll requested review from krebernisak and ferglor November 8, 2024 22:04
patrickhuie19
patrickhuie19 previously approved these changes Nov 8, 2024
@pkcll pkcll dismissed stale reviews from patrickhuie19 and jmank88 via 8bc9e7f November 8, 2024 22:23
patrickhuie19
patrickhuie19 previously approved these changes Nov 8, 2024
jmank88
jmank88 previously approved these changes Nov 8, 2024
@pkcll pkcll requested a review from a team as a code owner November 9, 2024 00:31
@pkcll pkcll force-pushed the beholder-use-batch-processor branch from e38e845 to 1b4ba84 Compare November 9, 2024 00:53
patrickhuie19
patrickhuie19 previously approved these changes Nov 9, 2024
@pkcll pkcll requested review from jmank88 and removed request for a team November 9, 2024 01:00
Copy link
Contributor

github-actions bot commented Nov 9, 2024

Flaky Test Detector for ./go.mod project has failed ❌

Ran new or updated tests between develop and 77b7992 (beholder-use-batch-processor).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 117 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                       TestName                                         PassRatio  RunCount   Skipped
---------                                                         ---------                                        ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  TestConfig_SetFrom/empty-full                    0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  TestConfig_SetFrom/full-empty                    0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  Test_generalConfig_LogConfiguration/empty        0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  Test_generalConfig_LogConfiguration/full         0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  Test_generalConfig_LogConfiguration/multi-chain  0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  TestConfig_SetFrom                               0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  TestConfig_Marshal                               0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  Test_generalConfig_LogConfiguration              0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  TestConfig_Marshal/full                          0%         1          false

Copy link
Contributor

github-actions bot commented Nov 9, 2024

Flaky Test Detector for ./go.mod project has failed ❌

Ran new or updated tests between develop and 1ad6d44 (beholder-use-batch-processor).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 117 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                       TestName                                         PassRatio  RunCount   Skipped
---------                                                         ---------                                        ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  Test_generalConfig_LogConfiguration              0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  Test_generalConfig_LogConfiguration/full         0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  TestConfig_Marshal                               0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  TestConfig_SetFrom/full-empty                    0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  TestConfig_Marshal/full                          0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  TestConfig_SetFrom/empty-full                    0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  Test_generalConfig_LogConfiguration/multi-chain  0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  TestConfig_SetFrom                               0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  Test_generalConfig_LogConfiguration/empty        0%         1          false

@cedric-cordenier cedric-cordenier added this pull request to the merge queue Nov 11, 2024
Merged via the queue into develop with commit 422e385 Nov 11, 2024
141 of 142 checks passed
@cedric-cordenier cedric-cordenier deleted the beholder-use-batch-processor branch November 11, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants