Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRIB-542: crib-integration-tests GH workflow running on push to develop #15221

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
+15 −3
Open

CRIB-542: crib-integration-tests GH workflow running on push to develop #15221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fcc6d6b
CRIB-542: crib-integration-tests GH workflow running on push to develop
rafaelfelix Nov 13, 2024
099f2af
crib-integration-test only runs on push to develop
rafaelfelix Nov 13, 2024
b63e15d
triggering crib-integration-test from build-publish-develop-pr (thank…
rafaelfelix Nov 14, 2024
21ed52c
running crib-integration-test.yml as a reusable workflow
rafaelfelix Dec 13, 2024
f90aeb7
limiting crib-integration-test to the develop branch
rafaelfelix Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/build-publish-develop-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,3 +154,11 @@ jobs:
goreleaser-release-type: "merge"
goreleaser-config: .goreleaser.develop.yaml
goreleaser-key: ${{ secrets.GORELEASER_KEY }}

crib-integration-test:
needs: [split, image-tag]
if: ${{ github.ref == 'refs/heads/develop' }}
uses: ./.github/workflows/crib-integration-test.yml
with:
image-tag: ${{ needs.image-tag.outputs.image-tag }}
secrets: inherit
10 changes: 7 additions & 3 deletions .github/workflows/crib-integration-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,13 @@ on:
pull_request:
paths:
- ".github/workflows/crib-integration-test.yml"
schedule:
- cron: "0 1 * * *"
workflow_call:
inputs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct me if I'm wrong, but is this going to trigger the test every time we merge into the develop branch? If that's true, a quick check shows there are 10+ PRs daily, resulting in at least 300 runs per month. This could cost us a significant amount of money, I suppose.
My questions are:

  • Do we want to spend money on a broken test? It will spin up some pods every time, only to fail.
  • Does it really make sense to enable it for every push to develop, considering we can't make it a mandatory check and we don't expect people to fix CRIB?

Maybe it would make sense to completely disable it for now. Once it's fixed, we could run it on a schedule (e.g., once daily) or trigger it by adding a specific label to PRs.

image-tag:
default: develop
required: false
description: The chainlink docker image tag to test against
type: string
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
Expand Down Expand Up @@ -89,7 +93,7 @@ jobs:
command: "core-dev-simulated-core-ocr1"
crib-alert-slack-webhook: ${{ secrets.CRIB_ALERT_SLACK_WEBHOOK }}
product-image: ${{ secrets.AWS_SDLC_ECR_HOSTNAME }}/chainlink
product-image-tag: develop
product-image-tag: ${{ inputs.image-tag }}
- uses: actions/[email protected]
- name: Set up Go
uses: ./.github/actions/setup-go
Expand Down
Loading