deployment: JD improvements #15239
deployment: JD improvements #15239
Conversation
|
I see you updated files related to
|
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
deployment/environment/devenv/don.go
Outdated
| @@ -367,7 +367,8 @@ func (n *Node) CreateJobDistributor(ctx context.Context, jd JobDistributor) (str | |||
| func (n *Node) SetUpAndLinkJobDistributor(ctx context.Context, jd JobDistributor) error { | |||
| // register the node in the job distributor | |||
| err := n.RegisterNodeToJobDistributor(ctx, jd) | |||
| if err != nil { | |||
| // TODO: check for rpc code = "AlreadyExists" instead | |||
| if err != nil && !strings.Contains(err.Error(), "AlreadyExists") { | |||
There was a problem hiding this comment.
so if the node is already registered in JD, we still want to continue?
There was a problem hiding this comment.
yeah I'm planning to change it so it's create or update, that way it's idempotent and can be re-ran (it's a total pain to wipe the config on all the nodes if you need to retry)
| msg := err.GetMessage() | ||
| return "", fmt.Errorf("failed to create feeds manager: %v", msg) | ||
| } | ||
| return "", fmt.Errorf("failed to create feeds manager: %v", response.GetCreateFeedsManager().GetTypename()) |
There was a problem hiding this comment.
can the response be nil at any point here?
There was a problem hiding this comment.
I think I found a better way of handling all these: converting to status.Status then handling the Code/Message values: https://github.com/grpc/grpc-go/blob/master/Documentation/rpc-errors.md
There was a problem hiding this comment.
actually that won't work, the error responses aren't returned as actual errors... we'll just have to write custom cases
There was a problem hiding this comment.
We have custom errors for loops that know how to translate to grpc and still match via errors.Is
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
No description provided.