Add write target beholder metrics #15255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
cedric-cordenier
approved these changes
Nov 15, 2024
| localMonitoring "github.com/smartcontractkit/chainlink/v2/core/monitoring" | ||
| ) | ||
|
|
||
| type writeTargetMetricsLabeler struct { |
There was a problem hiding this comment.
What's the goal of this metric? If we are going to emit failure metrics at the capability level, will this overlap with the capability level metrics you have PRs up for in the engine?
There was a problem hiding this comment.
Note that we are looking to add capability ID to at least one metric that tells us about step failures: https://github.com/smartcontractkit/chainlink/pull/15238/files#r1846939651
|
Closing in favor of #15238. Will update it so it has proper capability ID labeling for step failures. |
auto-merge was automatically disabled
November 21, 2024 16:52
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports