Initial v0.5.0 contracts #15273
Draft
Initial v0.5.0 contracts #15273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to |
Static analysis results are availableHey @Fletch153, you can view Slither reports in the job summary here or download them as artifact here. |
ad0ll
commented
Nov 15, 2024
| */ | ||
| contract Verifier is IVerifier, IVerifierProxyVerifier, ConfirmedOwner, TypeAndVersionInterface { | ||
| /// @notice Mapping of configDigest to Config, used to look up the verification configuration for the configDigest of the incoming report | ||
| mapping(bytes32 => CommonV5.Config) private s_Configs; |
There was a problem hiding this comment.
Change casing to s_configs
ad0ll
commented
Nov 18, 2024
| @@ -0,0 +1,820 @@ | |||
| { | |||
ad0ll
commented
Nov 18, 2024
| @@ -0,0 +1,20 @@ | |||
| // SPDX-License-Identifier: MIT | |||
There was a problem hiding this comment.
Library can be deprecated, move to Verifier.sol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports