Create tool to pin locally replaced modules to latest trunk commit #15290

chainchad · 2024-11-18T18:46:03Z

Run locally via: make gomodslocalupdate

Separating it to avoid potential merge conflicts when surrounding lines change as we expect CI to update its psuedo version.

github-actions · 2024-11-18T18:47:28Z

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

#added For any new functionality added.
#breaking_change For any functionality that requires manual action for the node to boot.
#bugfix For bug fixes.
#changed For any change to the existing functionality.
#db_update For any feature that introduces updates to database schema.
#deprecation_notice For any upcoming deprecation functionality.
#internal For changesets that need to be excluded from the final changelog.
#nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
#removed For any functionality/config that is removed.
#updated For any functionality that is updated.
#wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

tools/gomod-required-updater/README.md

chainchad · 2024-11-19T11:09:43Z

TODO

Add CI checks (lint, tests, build, ...)

tools/gomod-required-updater/README.md

tools/gomod-required-updater/internal/updater/config.go

tools/gomod-required-updater/internal/updater/git_operator.go

tools/gomod-required-updater/internal/updater/system_operator.go

tools/gomod-required-updater/internal/updater/updater.go

GNUmakefile

Tests and linting should now be ran from the ci-core workflow.

github-actions · 2024-11-23T23:30:39Z

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

GNUmakefile

Co-authored-by: Jordan Krage <[email protected]>

jmank88 · 2024-12-10T21:32:00Z

.github/workflows/ci-gomod-required-updater.yml

Is this separate workflow necessary?

Hm, it's pretty sparse right now. Would love to remove it. Would you suggest just throwing this as a step in ci-core.yml?

Well the make command already installs so what effect is this build meant to have?

The goal would be to ensure that the build doesn't break but maybe unnecessary or it gets built in another way that I'm not aware of?

It should already be covered by the normal CI as part of the root module. I.e. there should be a line for this package in the ci core test output

Makes sense, removed in ccf2842.

…ub.com/smartcontractkit/chainlink into re-3199/updater-root-module-go.mod-ref

chainchad added 3 commits November 15, 2024 14:34

Add separate require line for root module.

8192867

Separating it to avoid potential merge conflicts when surrounding lines change as we expect CI to update its psuedo version.

Create tool to update certain module deps to pin to latest trunk commit

8f5b382

Create new makefile target to use new tool to update module deps to pin

81968a8

jmank88 reviewed Nov 18, 2024

View reviewed changes

tools/gomod-required-updater/README.md Outdated Show resolved Hide resolved

chainchad added 4 commits November 19, 2024 07:49

Add support for additional local module replacements

1a1d9d3

Add support for automatically updating locally replaced modules

1e3811c

Update make target to auto update locally replaced modules

cb70261

Run go fmt

87e940f

chainchad commented Nov 19, 2024

View reviewed changes

tools/gomod-required-updater/README.md Outdated Show resolved Hide resolved

chainchad added 2 commits November 19, 2024 08:22

Add ci workflow

5b269ca

Add test for config sourcing

7165514

HenryNguyen5 reviewed Nov 19, 2024

View reviewed changes

jmank88 reviewed Nov 19, 2024

View reviewed changes

GNUmakefile Outdated Show resolved Hide resolved

chainchad added 13 commits November 21, 2024 15:51

Add build step to CI

979b0c1

Make it gomods compatible and not a separate module

99ad50b

Remove mocked sys op

b5dc9fb

Only build during dedicated CI workflow.

683ae99

Tests and linting should now be ran from the ci-core workflow.

Refactor

7358367

Remove unused function

e47bdd1

Use psuedo version from go lib

eb28c01

Upate pseudo-versions for local replaces to latest time/sha

9c22ee2

Cleanup

dd2390c

Update bin path

b9dc91a

Fix README

f8fbc9b

Allow custom org/repo name and apply better validation to git cmds

bf12443

Merge branch 'develop' into re-3199/updater-root-module-go.mod-ref

94a6f0f

Address linting

da8130b

jmank88 reviewed Dec 3, 2024

View reviewed changes

GNUmakefile Outdated Show resolved Hide resolved

chainchad and others added 8 commits December 6, 2024 16:18

Update README about usage and gomods

63638a7

Add gomods as a dep for new target

88c1b73

Co-authored-by: Jordan Krage <[email protected]>

Move pre-compiled regular expressions into vars

941e003

Fix formatting

833427a

Remove remnant from refactor

1d9497a

Move validation of git input into config

cbda2d1

Merge branch 'develop' into re-3199/updater-root-module-go.mod-ref

b53cec3

Run make gomodslocalupdate

b80bcfa

chainchad requested review from erikburt and jmank88 December 6, 2024 22:09

erikburt previously approved these changes Dec 6, 2024

View reviewed changes

Appease linter

89dd71b

chainchad dismissed erikburt’s stale review via 89dd71b December 7, 2024 00:09

chainchad added 3 commits December 7, 2024 12:15

Remove unnecessary inline comments

25864d1

Use a better name for git exec

4be3d94

Merge branch 'develop' into re-3199/updater-root-module-go.mod-ref

d0740ce

jmank88 reviewed Dec 10, 2024

View reviewed changes

chainchad added 2 commits December 10, 2024 16:46

Remove unnecessary build workflow

ccf2842

Merge branch 're-3199/updater-root-module-go.mod-ref' of https://gith…

737c8db

…ub.com/smartcontractkit/chainlink into re-3199/updater-root-module-go.mod-ref

jmank88 previously approved these changes Dec 10, 2024

View reviewed changes

Merge branch 'develop' into re-3199/updater-root-module-go.mod-ref

45efc1a

chainchad dismissed jmank88’s stale review via 45efc1a December 10, 2024 22:05

erikburt approved these changes Dec 10, 2024

View reviewed changes

chainchad requested a review from jmank88 December 10, 2024 22:08

jmank88 approved these changes Dec 10, 2024

View reviewed changes

chainchad added this pull request to the merge queue Dec 10, 2024

Merged via the queue into develop with commit 5bdf5c2 Dec 10, 2024
169 of 172 checks passed

chainchad deleted the re-3199/updater-root-module-go.mod-ref branch December 10, 2024 22:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create tool to pin locally replaced modules to latest trunk commit #15290

Create tool to pin locally replaced modules to latest trunk commit #15290

chainchad commented Nov 18, 2024 •

edited

Loading

github-actions bot commented Nov 18, 2024

chainchad commented Nov 19, 2024 •

edited

Loading

github-actions bot commented Nov 23, 2024 •

edited

Loading

jmank88 Dec 10, 2024

chainchad Dec 10, 2024

jmank88 Dec 10, 2024

chainchad Dec 10, 2024

jmank88 Dec 10, 2024

chainchad Dec 10, 2024

Create tool to pin locally replaced modules to latest trunk commit #15290

Create tool to pin locally replaced modules to latest trunk commit #15290

Conversation

chainchad commented Nov 18, 2024 • edited Loading

github-actions bot commented Nov 18, 2024

chainchad commented Nov 19, 2024 • edited Loading

github-actions bot commented Nov 23, 2024 • edited Loading

AER Report: CI Core ran successfully ✅

AER Report: Operator UI CI ran successfully ✅

jmank88 Dec 10, 2024

Choose a reason for hiding this comment

chainchad Dec 10, 2024

Choose a reason for hiding this comment

jmank88 Dec 10, 2024

Choose a reason for hiding this comment

chainchad Dec 10, 2024

Choose a reason for hiding this comment

jmank88 Dec 10, 2024

Choose a reason for hiding this comment

chainchad Dec 10, 2024

Choose a reason for hiding this comment

chainchad commented Nov 18, 2024 •

edited

Loading

chainchad commented Nov 19, 2024 •

edited

Loading

github-actions bot commented Nov 23, 2024 •

edited

Loading