CCIP-4302: Remove dependencies from integration-tests/ccip-tests/* #15321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:
|
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
b-gopalswami
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xnogo and
vyzaldysanchez
makramkd
reviewed
Nov 21, 2024
| @@ -647,3 +652,40 @@ func CreateChainConfigFromNetworks( | |||
| } | |||
| return chains | |||
| } | |||
|
|
|||
| func SetNodeConfig(nets []blockchain.EVMNetwork, nodeConfig, commonChain string, configByChain map[string]string) (*corechainlink.Config, string, error) { | |||
There was a problem hiding this comment.
It is used within StartChainlinkNodes
makramkd
approved these changes
Nov 21, 2024
asoliman92
approved these changes
Nov 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have removed all dependencies on integration-tests/ccip-tests/* in v1.6 tests. Also, added ccip directory under smoke and moved all ccip tests under it.