Remove duplicated testing util for p2p_key only. #15330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
pavel-raykov
changed the title
pavel-raykov
changed the title
jmank88
previously approved these changes
Nov 20, 2024
jmank88
approved these changes
Nov 21, 2024
pavel-raykov
requested review from
a team,
eutopian and
yevshev
as code owners
bolekk
approved these changes
Nov 21, 2024
This was referenced Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed code can be substituted with MustNewV2XXXTestingOnly.
Nit: for some tests (like TestIntegration_OCR2_ForwarderFlow) it is important that the created keys are unique, this used to be the case when the keys were created at random (with overwhelming probability) and is not achieved by using the node's port as its key's seed.