-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ccip/changeset/internal #15334
Add ccip/changeset/internal #15334
Conversation
AER Report: CI Coreaer_workflow , commit , Detect Changes , Scheduled Run Frequency , Clean Go Tidy & Generate , Find New Flaky Tests In Chainlink Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Find New Flaky Tests In Deployment Project / Get Tests To Run , Find New Flaky Tests In Chainlink Project / Run Tests , Find New Flaky Tests In Chainlink Project / Report , Find New Flaky Tests In Deployment Project / Run Tests (github.com/smartcontractkit/chainlink/deployment/ccip/changeset, ubuntu-latest) , Flakey Test Detection , SonarQube Scan , Find New Flaky Tests In Deployment Project / Report 1. No space left on device:[Run tests with flakeguard]Source of Error:
Why: The error indicates that the device ran out of disk space, preventing the build process from writing necessary files and completing the linking stage. Suggested fix: Ensure that there is sufficient disk space available on the device before running the tests. Clean up unnecessary files or increase the disk space allocation. 2. Running gcc failed: exit status 1:[Run tests with flakeguard]Source of Error:
Why: This error is a consequence of the "No space left on device" error. The gcc compiler failed to complete its task due to insufficient disk space. Suggested fix: Resolve the disk space issue as suggested above. Once there is enough space, the gcc compiler should be able to run successfully. 3. Invalid character 'g' looking for beginning of value:[Run tests with flakeguard]Source of Error:
Why: This error likely occurred because the JSON output from the test results was corrupted or incomplete, possibly due to the previous errors related to disk space. Suggested fix: After resolving the disk space issue, ensure that the test output is correctly generated and properly formatted as JSON. Re-run the tests to verify. AER Report: Operator UI CI ran successfully ✅ |
@@ -0,0 +1,536 @@ | |||
package internal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just took one file to use as an example. There is a lot more we can hide in internal
We want to reduce the public API surface of deployment/ccip and be more careful about the public API. To accomplish that:
At that point ccip/changeset and ccip/view represent the public API and internal holds details. This ensures that the integration-tests and chainlink-deployments modules don't import stuff we don't want them to.