Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ccip/changeset/internal #15334

Merged
merged 11 commits into from
Nov 20, 2024
Merged

Add ccip/changeset/internal #15334

merged 11 commits into from
Nov 20, 2024

Conversation

connorwstein
Copy link
Contributor

@connorwstein connorwstein commented Nov 20, 2024

We want to reduce the public API surface of deployment/ccip and be more careful about the public API. To accomplish that:

  • Moving the ccip/*.go files (ccipdeployment package) into ccip/changeset
  • Move any easy files into ccip/changeset/internal
  • Follow up: further pull logic into ccip/changeset/internal

At that point ccip/changeset and ccip/view represent the public API and internal holds details. This ensures that the integration-tests and chainlink-deployments modules don't import stuff we don't want them to.

Copy link
Contributor

github-actions bot commented Nov 20, 2024

AER Report: CI Core

aer_workflow , commit , Detect Changes , Scheduled Run Frequency , Clean Go Tidy & Generate , Find New Flaky Tests In Chainlink Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Find New Flaky Tests In Deployment Project / Get Tests To Run , Find New Flaky Tests In Chainlink Project / Run Tests , Find New Flaky Tests In Chainlink Project / Report , Find New Flaky Tests In Deployment Project / Run Tests (github.com/smartcontractkit/chainlink/deployment/ccip/changeset, ubuntu-latest) , Flakey Test Detection , SonarQube Scan , Find New Flaky Tests In Deployment Project / Report

1. No space left on device:[Run tests with flakeguard]

Source of Error:
Run tests with flakeguard	2024-11-20T17:03:03.0025257Z github.com/uber/jaeger-client-go/thrift-gen/baggage: write /tmp/go-build4103662097/b1718/vet.cfg: no space left on device
Run tests with flakeguard	2024-11-20T17:03:03.0083925Z /usr/bin/ld: final link failed: No space left on device
Run tests with flakeguard	2024-11-20T17:03:03.0084447Z collect2: error: ld returned 1 exit status

Why: The error indicates that the device ran out of disk space, preventing the build process from writing necessary files and completing the linking stage.

Suggested fix: Ensure that there is sufficient disk space available on the device before running the tests. Clean up unnecessary files or increase the disk space allocation.

2. Running gcc failed: exit status 1:[Run tests with flakeguard]

Source of Error:
Run tests with flakeguard	2024-11-20T17:03:03.0030289Z /opt/hostedtoolcache/go/1.23.3/x64/pkg/tool/linux_amd64/link: running gcc failed: exit status 1

Why: This error is a consequence of the "No space left on device" error. The gcc compiler failed to complete its task due to insufficient disk space.

Suggested fix: Resolve the disk space issue as suggested above. Once there is enough space, the gcc compiler should be able to run successfully.

3. Invalid character 'g' looking for beginning of value:[Run tests with flakeguard]

Source of Error:
Run tests with flakeguard	2024-11-20T17:03:03.0092488Z error: invalid character 'g' looking for beginning of value

Why: This error likely occurred because the JSON output from the test results was corrupted or incomplete, possibly due to the previous errors related to disk space.

Suggested fix: After resolving the disk space issue, ensure that the test output is correctly generated and properly formatted as JSON. Re-run the tests to verify.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@@ -0,0 +1,536 @@
package internal
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just took one file to use as an example. There is a lot more we can hide in internal

@connorwstein connorwstein marked this pull request as ready for review November 20, 2024 15:45
@connorwstein connorwstein requested review from a team as code owners November 20, 2024 15:45
@connorwstein connorwstein requested a review from a team as a code owner November 20, 2024 15:47
jmank88
jmank88 previously approved these changes Nov 20, 2024
AnieeG
AnieeG previously approved these changes Nov 20, 2024
@connorwstein connorwstein dismissed stale reviews from AnieeG and jmank88 via 77f1199 November 20, 2024 16:11
makramkd
makramkd previously approved these changes Nov 20, 2024
@connorwstein connorwstein added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2024
@AnieeG AnieeG added this pull request to the merge queue Nov 20, 2024
Merged via the queue into develop with commit 789d021 Nov 20, 2024
165 of 167 checks passed
@AnieeG AnieeG deleted the ccip-deploy-internal-pkg branch November 20, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants