-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: conditionally run unit tests #15347
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikburt
force-pushed
the
feat/go-test-binary-comparison
branch
10 times, most recently
from
November 27, 2024 19:30
0b75b37
to
3ebea69
Compare
erikburt
force-pushed
the
feat/go-test-binary-comparison
branch
6 times, most recently
from
December 4, 2024 17:46
13976e4
to
d501ceb
Compare
erikburt
force-pushed
the
feat/go-test-binary-comparison
branch
from
December 5, 2024 20:41
74713e7
to
a03ce66
Compare
erikburt
force-pushed
the
feat/go-test-binary-comparison
branch
from
December 5, 2024 21:03
a03ce66
to
6467b19
Compare
chainchad
previously approved these changes
Dec 6, 2024
Did some testing trying to see if I could speed up test binary building through caching. It seems like the cache saving doesn't work when the composite action is nested.
chainchad
approved these changes
Dec 9, 2024
kalverra
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
setup-ci-core-tests
, which consolidates the some of setup for the testsci-core-partial
which uses the node action from action: go conditional tests .github#709 to only run test binaries with changesTesting
Workflow running all tests, and updating index: https://github.com/smartcontractkit/chainlink/actions/runs/12187711071/job/33999115005?pr=15347
- This workflow ran all tests because the index had been previously updated with hashes from binaries built with coverage flags. Note: this won't happen during normal execution because coverage being enabled actually causes the workflow to skip updating the hash.
Workflow running no tests: https://github.com/smartcontractkit/chainlink/actions/runs/12188016602/job/34000123940?pr=15347
Test package concurrency of 16 seemed more stable than 32.
Rollout
Run this alongside existing validation for at least a week. Only after we've confirmed that the new validation mechanism is working as expected should we replace the existing validation.
RE-3168