Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ccip-4158 - Initial Add Chain changeset #15349

Merged
merged 33 commits into from
Nov 21, 2024
Merged
Show file tree
Hide file tree
Changes from 31 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
e6653a3
Move files
connorwstein Nov 20, 2024
95fd35a
Move more files
connorwstein Nov 20, 2024
654f326
Move the rest
connorwstein Nov 20, 2024
d8fc0dc
Move some files to internal
connorwstein Nov 20, 2024
edb4eb9
Get building
connorwstein Nov 20, 2024
b375b3c
Move a bunch of home chain stuff to internal
connorwstein Nov 20, 2024
17ca535
Update README
connorwstein Nov 20, 2024
77f1199
Fix integration tests
connorwstein Nov 20, 2024
74eb6ca
Fix merge conflicts
connorwstein Nov 20, 2024
b408fbd
Merge branch 'develop' of github.com:smartcontractkit/chainlink into …
AnieeG Nov 20, 2024
8e9de17
More merge conflicts
connorwstein Nov 20, 2024
7d2bd9c
More merge conflicts
connorwstein Nov 20, 2024
ef60262
updates
AnieeG Nov 20, 2024
86b516f
Merge branch 'develop' of github.com:smartcontractkit/chainlink into …
AnieeG Nov 20, 2024
52dbb43
Merge branch 'ccip-deploy-internal-pkg' of github.com:smartcontractki…
AnieeG Nov 20, 2024
aa9e9c9
changes
AnieeG Nov 20, 2024
374c0d5
changes
AnieeG Nov 20, 2024
3612d8e
Merge branch 'develop' of github.com:smartcontractkit/chainlink into …
AnieeG Nov 20, 2024
7fba91d
changes
AnieeG Nov 20, 2024
b53d58a
more changes
AnieeG Nov 20, 2024
defa97f
fix go mod
AnieeG Nov 20, 2024
43c58a3
quick fix
AnieeG Nov 20, 2024
a662514
fix tests
AnieeG Nov 20, 2024
060c7fe
more optimize
AnieeG Nov 21, 2024
55f9099
more fix
AnieeG Nov 21, 2024
b2128b4
remove unnecessary methods
AnieeG Nov 21, 2024
ea1bc14
fix review comments
AnieeG Nov 21, 2024
baa87c0
fix conflict
AnieeG Nov 21, 2024
49dcad3
fixes
AnieeG Nov 21, 2024
7cb2a62
add a test
AnieeG Nov 21, 2024
8d4a5bb
more fix
AnieeG Nov 21, 2024
9ca4940
more review comments
AnieeG Nov 21, 2024
321539e
fix ApplyChangesets
AnieeG Nov 21, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion deployment/ccip/changeset/active_candidate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"github.com/smartcontractkit/ccip-owner-contracts/pkg/proposal/timelock"

"github.com/smartcontractkit/chainlink-testing-framework/lib/utils/testcontext"

"github.com/smartcontractkit/chainlink/deployment/ccip/changeset/internal"
cctypes "github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/types"
"github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/router"
Expand All @@ -25,7 +26,7 @@ func TestActiveCandidate(t *testing.T) {
t.Skipf("to be enabled after latest cl-ccip is compatible")

lggr := logger.TestLogger(t)
tenv := NewMemoryEnvironmentWithJobsAndContracts(t, lggr, 3, 5)
tenv := NewMemoryEnvironmentWithJobsAndContracts(t, lggr, 3, 5, nil)
e := tenv.Env
state, err := LoadOnchainState(tenv.Env)
require.NoError(t, err)
Expand Down
9 changes: 5 additions & 4 deletions deployment/ccip/changeset/add_chain_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func TestAddChainInbound(t *testing.T) {
// We deploy to the rest.
initialDeploy := e.Env.AllChainSelectorsExcluding([]uint64{newChain})
newAddresses := deployment.NewMemoryAddressBook()
err = DeployPrerequisiteChainContracts(e.Env, newAddresses, initialDeploy)
err = deployPrerequisiteChainContracts(e.Env, newAddresses, initialDeploy, nil)
require.NoError(t, err)
require.NoError(t, e.Env.ExistingAddresses.Merge(newAddresses))

Expand All @@ -59,15 +59,15 @@ func TestAddChainInbound(t *testing.T) {
require.NoError(t, e.Env.ExistingAddresses.Merge(out.AddressBook))
newAddresses = deployment.NewMemoryAddressBook()
tokenConfig := NewTestTokenConfig(state.Chains[e.FeedChainSel].USDFeeds)
err = DeployCCIPContracts(e.Env, newAddresses, DeployCCIPContractConfig{
err = DeployCCIPContracts(e.Env, newAddresses, NewChainsConfig{
HomeChainSel: e.HomeChainSel,
FeedChainSel: e.FeedChainSel,
ChainsToDeploy: initialDeploy,
TokenConfig: tokenConfig,
OCRSecrets: deployment.XXXGenerateTestOCRSecrets(),
})
require.NoError(t, err)
require.NoError(t, e.Env.ExistingAddresses.Merge(newAddresses))

state, err = LoadOnchainState(e.Env)
require.NoError(t, err)

Expand All @@ -94,7 +94,8 @@ func TestAddChainInbound(t *testing.T) {
require.NoError(t, e.Env.ExistingAddresses.Merge(out.AddressBook))

newAddresses = deployment.NewMemoryAddressBook()
err = DeployPrerequisiteChainContracts(e.Env, newAddresses, []uint64{newChain})

err = deployPrerequisiteChainContracts(e.Env, newAddresses, []uint64{newChain}, nil)
require.NoError(t, err)
require.NoError(t, e.Env.ExistingAddresses.Merge(newAddresses))
newAddresses = deployment.NewMemoryAddressBook()
Expand Down
3 changes: 2 additions & 1 deletion deployment/ccip/changeset/add_lane_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (

commonutils "github.com/smartcontractkit/chainlink-common/pkg/utils"
"github.com/smartcontractkit/chainlink-testing-framework/lib/utils/testcontext"

"github.com/smartcontractkit/chainlink/deployment"
"github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/offramp"
"github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/router"
Expand All @@ -20,7 +21,7 @@ import (
func TestAddLane(t *testing.T) {
t.Parallel()
// We add more chains to the chainlink nodes than the number of chains where CCIP is deployed.
e := NewMemoryEnvironmentWithJobsAndContracts(t, logger.TestLogger(t), 2, 4)
e := NewMemoryEnvironmentWithJobsAndContracts(t, logger.TestLogger(t), 2, 4, nil)
// Here we have CR + nodes set up, but no CCIP contracts deployed.
state, err := LoadOnchainState(e.Env)
require.NoError(t, err)
Expand Down
Loading
Loading