Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keystone] Disable remote calls to RegisterToWorkflow #15352

Merged
merged 2 commits into from
Nov 21, 2024
Merged

[Keystone] Disable remote calls to RegisterToWorkflow #15352

merged 2 commits into from
Nov 21, 2024

Conversation

bolekk
Copy link
Contributor

@bolekk bolekk commented Nov 21, 2024 •
edited
Loading

Until implemented properly (see Slack thread).

@bolekk bolekk requested review from a team as code owners November 21, 2024 01:52
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

justinkaseman
justinkaseman previously approved these changes Nov 21, 2024
View reviewed changes
MStreet3
MStreet3 previously approved these changes Nov 21, 2024
View reviewed changes
ettec
ettec previously approved these changes Nov 21, 2024
View reviewed changes
@cedric-cordenier cedric-cordenier dismissed stale reviews from ettec, MStreet3, and themself via d679cb6 November 21, 2024 11:02
@cedric-cordenier cedric-cordenier force-pushed the fix/remove_registertoworkflow branch 2 times, most recently from d679cb6 to 2d63415 Compare November 21, 2024 12:24
@cedric-cordenier cedric-cordenier force-pushed the fix/remove_registertoworkflow branch from 2d63415 to ebd267c Compare November 21, 2024 12:42
@justinkaseman justinkaseman self-requested a review November 21, 2024 15:53
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Nov 21, 2024
Merged via the queue into develop with commit e4a2914 Nov 21, 2024
145 of 146 checks passed
@cedric-cordenier cedric-cordenier deleted the fix/remove_registertoworkflow branch November 21, 2024 16:15
bolekk added a commit that referenced this pull request Nov 21, 2024
@bolekk @cedric-cordenier
[Keystone] Disable remote calls to RegisterToWorkflow (#15352)
b25d5fb 
* [Keystone] Disable remote calls to RegisterToWorkflow

* Remove failing test

---------

Co-authored-by: Cedric Cordenier <[email protected]>
@bolekk bolekk mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkaseman justinkaseman justinkaseman approved these changes

@krehermann krehermann krehermann approved these changes

@ettec ettec ettec left review comments

@MStreet3 MStreet3 MStreet3 left review comments

@cedric-cordenier cedric-cordenier Awaiting requested review from cedric-cordenier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bolekk @MStreet3 @krehermann @cedric-cordenier @justinkaseman @ettec